Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2463 - E2E Tests - Workflow - Part-time Grants Eligibility #2506

Merged
merged 11 commits into from
Nov 16, 2023
Merged

#2463 - E2E Tests - Workflow - Part-time Grants Eligibility #2506

merged 11 commits into from
Nov 16, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Nov 14, 2023 •
edited
Loading

  • Created E2E test for part-time awards.
  • Fixed the syntax error for SBSD in camunda workflow.
    image
    Screenshots
    CSPT
    image
    CSGP
    image
    CSGD
    image
    BCAG
    image
    SBSD
    image
  • Copied and pasted the existing full-time eligibility TCs for other program years too.

@ann-aot ann-aot added E2E/Unit tests Camunda Worflow Involves camunda workflow changes labels Nov 14, 2023
@ann-aot ann-aot self-assigned this Nov 14, 2023
andrepestana-aot
andrepestana-aot reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left some comments.

dheepak-aot
dheepak-aot reviewed Nov 15, 2023
View reviewed changes
...est/2023-2024/parttime-assessment/parttime-assessment-2023-2024-eligibility-CSGD.e2e-spec.ts Outdated
const assessmentConsolidatedData =
createFakeConsolidatedPartTimeData(PROGRAM_YEAR);
// No total eligible dependant.
assessmentConsolidatedData.studentDataDependants = undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default it is null, do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to show explicitly the scenario mentioned in the description, as we do for other TC

dheepak-aot
dheepak-aot reviewed Nov 15, 2023
View reviewed changes
...est/2023-2024/parttime-assessment/parttime-assessment-2023-2024-eligibility-SBSD.e2e-spec.ts Outdated
InstitutionTypes.BCPrivate,
];

describe("Should determine SBSD as eligible when total assessment need is greater than or equal to 1, application PD/PPD status is 'yes' and", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment could be explicit about institution type. (BCPublic or BCPrivate)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

dheepak-aot
dheepak-aot reviewed Nov 15, 2023
View reviewed changes
...est/2023-2024/parttime-assessment/parttime-assessment-2023-2024-eligibility-SBSD.e2e-spec.ts Outdated
}
});

it(`Should determine SBSD as not eligible when institution type is ${InstitutionTypes.International}.`, async () => {
Copy link
Collaborator

@dheepak-aot dheepak-aot Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment could be explicit about institution type. (BCPublic or BCPrivate).

The test can also run for both BC public and private like the way we did for credential types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not understandable?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I later edited my comment mentioning we can run a test for bcpublic and bcprivate and one outside this for negative scenario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already happening, The first Tc of this test suite
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not refresh the source code downloaded to local. All good now 😊

@dheepak-aot
Copy link
Collaborator

Great job @ann-aot . Added few comments.

dheepak-aot
dheepak-aot approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes 👍

andrepestana-aot
andrepestana-aot approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Looks good!

guru-aot
guru-aot approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ann-aot

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.99% ( 2612 / 13065 )
Methods: 10.43% ( 173 / 1658 )
Lines: 22.78% ( 2252 / 9887 )
Branches: 12.3% ( 187 / 1520 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.08% ( 4064 / 7379 )
Methods: 51.98% ( 499 / 960 )
Lines: 59.83% ( 3298 / 5512 )
Branches: 29.44% ( 267 / 907 )

andrewsignori-aot
andrewsignori-aot approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, looks good 👍

@ann-aot ann-aot merged commit 0554472 into main Nov 16, 2023
15 checks passed
@ann-aot ann-aot deleted the e2e/sims-#2463 branch November 16, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@cditcher cditcher Awaiting requested review from cditcher

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
Camunda Worflow Involves camunda workflow changes E2E/Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ann-aot @dheepak-aot @andrewsignori-aot @guru-aot @andrepestana-aot