-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2288 - Load test gateway devops and local docker #2487
Conversation
- apiVersion: autoscaling/v1 | ||
kind: HorizontalPodAutoscaler | ||
metadata: | ||
name: ${NAME}-hpa | ||
spec: | ||
scaleTargetRef: | ||
apiVersion: apps/v1 | ||
kind: ReplicationController | ||
name: ${NAME}-rc | ||
minReplicas: "${{REPLICAS}}" | ||
maxReplicas: 10 | ||
targetCPUUtilizationPercentage: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need autoscaling for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend not using it. Before the test, it would be good to have them scaled to what we believe would be best to avoid new pods creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just left a comment.
Please check the sonar issues. |
@@ -14,7 +14,7 @@ import { ClientSecretCredential } from "../../utils/auth"; | |||
/** | |||
* Load test number of iterations to run. | |||
*/ | |||
const ITERATIONS = 500; | |||
const ITERATIONS = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change on purpose to keep the number low for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not intentional 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this into the current effort. Please take a look at the comments.
I believe that we need a ticket to have the GitHub actions available to do the DEV/TEST build deploy.
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for extending the work and making the DevOps part also compled in the ticket. Look good 👍
@@ -433,6 +449,32 @@ deploy-queue-consumers: | |||
| oc -n $(NAMESPACE) apply -f - | |||
$(call rollout_and_wait,dc/$(QUEUE_CONSUMERS)) | |||
|
|||
deploy-load-test-gateway: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for discussion, if we use this container only for load-testing, can this be used for db-migrations too? If we properly spin this up and adding the db-migrations in the Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is no intention to use this container for db migrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This container may be deployed only to DEV, it may be not present always, and I am struggling to see a benefit in doing it. Can you please provide a benefit for doing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a temporary container used for load-test, so I thought instead of having 2 jobs, if we extend it for db-migrations, we can use it during revert. I am aware that this may be only deployed in DEV, in case if we extend its functionalities as a common container, I was suggesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @dheepak-aot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @dheepak-aot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @dheepak-aot
load-test-gateway
in openshift