Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2288 - Load test gateway devops and local docker #2487

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Nov 8, 2023

  • Created deploy.yml and update make to deploy the load-test-gateway in openshift
  • Created local make and docker compose for load test gateway
    image

image

Comment on lines 113 to 124
- apiVersion: autoscaling/v1
kind: HorizontalPodAutoscaler
metadata:
name: ${NAME}-hpa
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: ReplicationController
name: ${NAME}-rc
minReplicas: "${{REPLICAS}}"
maxReplicas: 10
targetCPUUtilizationPercentage: 80
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need autoscaling for this one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend not using it. Before the test, it would be good to have them scaled to what we believe would be best to avoid new pods creation.

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just left a comment.

@andrepestana-aot
Copy link
Collaborator

Please check the sonar issues.

@@ -14,7 +14,7 @@ import { ClientSecretCredential } from "../../utils/auth";
/**
* Load test number of iterations to run.
*/
const ITERATIONS = 500;
const ITERATIONS = 15;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change on purpose to keep the number low for now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not intentional 😊

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this into the current effort. Please take a look at the comments.
I believe that we need a ticket to have the GitHub actions available to do the DEV/TEST build deploy.

Copy link

sonarqubecloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

github-actions bot commented Nov 8, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.89% ( 2579 / 12967 )
Methods: 10.37% ( 170 / 1639 )
Lines: 22.65% ( 2224 / 9817 )
Branches: 12.24% ( 185 / 1511 )

Copy link

github-actions bot commented Nov 8, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

Copy link

github-actions bot commented Nov 8, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

Copy link

github-actions bot commented Nov 8, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.3% ( 4031 / 7289 )
Methods: 52.44% ( 495 / 944 )
Lines: 60.06% ( 3271 / 5446 )
Branches: 29.48% ( 265 / 899 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for extending the work and making the DevOps part also compled in the ticket. Look good 👍

@@ -433,6 +449,32 @@ deploy-queue-consumers:
| oc -n $(NAMESPACE) apply -f -
$(call rollout_and_wait,dc/$(QUEUE_CONSUMERS))

deploy-load-test-gateway:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for discussion, if we use this container only for load-testing, can this be used for db-migrations too? If we properly spin this up and adding the db-migrations in the Dockerfile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is no intention to use this container for db migrations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container may be deployed only to DEV, it may be not present always, and I am struggling to see a benefit in doing it. Can you please provide a benefit for doing it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a temporary container used for load-test, so I thought instead of having 2 jobs, if we extend it for db-migrations, we can use it during revert. I am aware that this may be only deployed in DEV, in case if we extend its functionalities as a common container, I was suggesting.

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dheepak-aot 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job!

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @dheepak-aot 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @dheepak-aot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants