#2288 - Load test gateway devops and local docker #2487
Conversation
dheepak-aot
requested review from
guru-aot,
sh16011993,
cditcher,
andrewsignori-aot,
ann-aot,
andrepestana-aot and
JasonCTang
| - apiVersion: autoscaling/v1 | ||
| kind: HorizontalPodAutoscaler | ||
| metadata: | ||
| name: ${NAME}-hpa | ||
| spec: | ||
| scaleTargetRef: | ||
| apiVersion: apps/v1 | ||
| kind: ReplicationController | ||
| name: ${NAME}-rc | ||
| minReplicas: "${{REPLICAS}}" | ||
| maxReplicas: 10 | ||
| targetCPUUtilizationPercentage: 80 |
There was a problem hiding this comment.
Do we need autoscaling for this one?
There was a problem hiding this comment.
I would recommend not using it. Before the test, it would be good to have them scaled to what we believe would be best to avoid new pods creation.
|
Please check the sonar issues. |
| @@ -14,7 +14,7 @@ import { ClientSecretCredential } from "../../utils/auth"; | |||
| /** | |||
| * Load test number of iterations to run. | |||
| */ | |||
| const ITERATIONS = 500; | |||
| const ITERATIONS = 15; | |||
There was a problem hiding this comment.
Is this change on purpose to keep the number low for now?
There was a problem hiding this comment.
It was not intentional 😊
|
SonarCloud Quality Gate failed.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
| @@ -433,6 +449,32 @@ deploy-queue-consumers: | |||
| | oc -n $(NAMESPACE) apply -f - | |||
| $(call rollout_and_wait,dc/$(QUEUE_CONSUMERS)) | |||
|
|
|||
| deploy-load-test-gateway: | |||
There was a problem hiding this comment.
Just for discussion, if we use this container only for load-testing, can this be used for db-migrations too? If we properly spin this up and adding the db-migrations in the Dockerfile?
There was a problem hiding this comment.
I believe there is no intention to use this container for db migrations.
There was a problem hiding this comment.
This container may be deployed only to DEV, it may be not present always, and I am struggling to see a benefit in doing it. Can you please provide a benefit for doing it?
There was a problem hiding this comment.
This was a temporary container used for load-test, so I thought instead of having 2 jobs, if we extend it for db-migrations, we can use it during revert. I am aware that this may be only deployed in DEV, in case if we extend its functionalities as a common container, I was suggesting.
load-test-gatewayin openshift