#2383 - Horizontal Autoscaler from replication controller to deployment config #2485

guru-aot · 2023-11-08T01:16:38Z

Horizontal autoscaler target needs to be changed from Replication controller to deployment config.
Apply the Horizontal autoscaler for the pods, change the deploy.yaml and apply them during the deployments.

Without HPA not properly assigned

With HPA properly assigned

Formio Load testing
WIth 2 pods it scaled up to 6 pods for 400 Vu

With 6 pods running the same sets of load for 400 Vu

With 6 pods running 300 Vu

With 6 pods running 200 Vu

With 6 pods running 100 Vu

With 2 pods running 100 Vu it started the 3rd pod

dheepak-aot · 2023-11-10T22:50:21Z

devops/openshift/api-deploy.yml

@@ -225,18 +225,30 @@ objects:
      to:
        kind: Service
        name: ${NAME}
-  - apiVersion: autoscaling/v1
+  - apiVersion: autoscaling/v2


dheepak-aot · 2023-11-10T22:54:02Z

devops/openshift/api-deploy.yml

+              name: cpu
+              target:
+                type: AverageValue
+                averageValue: '0.18'


Asking for my clarification, how did we arrive at this average value?

90% of the CPU limit

dheepak-aot · 2023-11-10T22:54:18Z

devops/openshift/api-deploy.yml

+              name: memory
+              target:
+                type: AverageValue
+                averageValue: "230M"


90% of the Memory limit

dheepak-aot · 2023-11-10T22:57:57Z

devops/openshift/forms-deploy.yml

+              name: memory
+              target:
+                type: AverageValue
+                averageValue: "1Gi"


I see higher numbers for form.io server than API for autoscaling, is this with consideration that form.io server is going to have lighter load than API?

No, the averageValue is a percentage of the CPU and memory limits and here for formio, we have used the 50% as we used in the previous load testing iterations, this inturn helps for pods scaling without many requests failing.

Got it. Thanks for explaining. If 50% then cpu must be 0.75 ?

Yeah you are right, i did increased a bit and tested around so gave those value.

dheepak-aot

Great job 👍

andrepestana-aot

Looks good! Good job!

devops/openshift/api-deploy.yml

andrewsignori-aot

Great work. Just one really minor comment.
Let's talk about extending or having a second ticket to implement the scaleDown behavior if needed.
Besides that, once deployed I would like to see the API autoscaling load test 😉

ann-aot

👍 Thanks for the details

sonarqubecloud · 2023-11-15T18:01:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-11-15T18:02:04Z

Backend Unit Tests Coverage Report

Totals
Statements:	19.99% ( 2612 / 13065 )
Methods:	10.43% ( 173 / 1658 )
Lines:	22.78% ( 2252 / 9887 )
Branches:	12.3% ( 187 / 1520 )

github-actions · 2023-11-15T18:02:52Z

E2E Workflow Workers Coverage Report

Totals
Statements:	52.62% ( 341 / 648 )
Methods:	50% ( 40 / 80 )
Lines:	56.85% ( 282 / 496 )
Branches:	26.39% ( 19 / 72 )

github-actions · 2023-11-15T18:03:21Z

E2E Queue Consumers Coverage Report

Totals
Statements:	76.94% ( 564 / 733 )
Methods:	71.59% ( 63 / 88 )
Lines:	78.75% ( 493 / 626 )
Branches:	42.11% ( 8 / 19 )

github-actions · 2023-11-15T18:05:53Z

E2E SIMS API Coverage Report

Totals
Statements:	55.08% ( 4064 / 7379 )
Methods:	51.98% ( 499 / 960 )
Lines:	59.83% ( 3298 / 5512 )
Branches:	29.44% ( 267 / 907 )

andrewsignori-aot

Thanks for doing the changes, looks good 👍

updated

6e23846

guru-aot self-assigned this Nov 8, 2023

guru-aot changed the title ~~#2382 - Horizontal Autoscaler from replication controller to deployment config~~ #2383 - Horizontal Autoscaler from replication controller to deployment config Nov 8, 2023

guru-aot had a problem deploying to DEV November 8, 2023 01:19 — with GitHub Actions Error

updated

5d53ac5

guru-aot marked this pull request as ready for review November 8, 2023 01:46

guru-aot added the Devops Devops label Nov 8, 2023

guru-aot requested review from cditcher, dheepak-aot, andrewsignori-aot, ann-aot, andrepestana-aot, JasonCTang and sh16011993 November 8, 2023 01:47

andrewsignori-aot marked this pull request as draft November 8, 2023 18:31

guru-aot added 3 commits November 8, 2023 16:58

updated

5596708

Merge branch 'main' into #2383_Horizontal_Autoscaler

eb83ef1

updated

b865a03

guru-aot marked this pull request as ready for review November 10, 2023 21:10

dheepak-aot reviewed Nov 10, 2023

View reviewed changes

dheepak-aot approved these changes Nov 10, 2023

View reviewed changes

andrepestana-aot approved these changes Nov 11, 2023

View reviewed changes

andrewsignori-aot reviewed Nov 11, 2023

View reviewed changes

devops/openshift/api-deploy.yml Show resolved Hide resolved

andrewsignori-aot reviewed Nov 11, 2023

View reviewed changes

ann-aot approved these changes Nov 14, 2023

View reviewed changes

updated

6fe749e

andrewsignori-aot approved these changes Nov 15, 2023

View reviewed changes

guru-aot merged commit 31e5983 into main Nov 15, 2023
15 checks passed

guru-aot deleted the #2383_Horizontal_Autoscaler branch November 15, 2023 18:11

guru-aot temporarily deployed to DEV November 15, 2023 18:24 — with GitHub Actions Inactive

guru-aot temporarily deployed to DEV November 15, 2023 18:25 — with GitHub Actions Inactive

guru-aot had a problem deploying to DEV November 15, 2023 18:29 — with GitHub Actions Failure

guru-aot temporarily deployed to DEV November 15, 2023 18:29 — with GitHub Actions Inactive

guru-aot temporarily deployed to DEV November 15, 2023 20:08 — with GitHub Actions Inactive

guru-aot had a problem deploying to DEV November 15, 2023 20:08 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2383 - Horizontal Autoscaler from replication controller to deployment config #2485

#2383 - Horizontal Autoscaler from replication controller to deployment config #2485

guru-aot commented Nov 8, 2023 •

edited

Loading

dheepak-aot Nov 10, 2023

dheepak-aot Nov 10, 2023

guru-aot Nov 10, 2023

dheepak-aot Nov 10, 2023

guru-aot Nov 10, 2023

dheepak-aot Nov 10, 2023

guru-aot Nov 10, 2023

dheepak-aot Nov 10, 2023

guru-aot Nov 10, 2023

dheepak-aot left a comment

andrepestana-aot left a comment

andrewsignori-aot left a comment

ann-aot left a comment

sonarqubecloud bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

andrewsignori-aot left a comment

#2383 - Horizontal Autoscaler from replication controller to deployment config #2485

#2383 - Horizontal Autoscaler from replication controller to deployment config #2485

Conversation

guru-aot commented Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot left a comment

Choose a reason for hiding this comment

andrepestana-aot left a comment

Choose a reason for hiding this comment

andrewsignori-aot left a comment

Choose a reason for hiding this comment

ann-aot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 15, 2023

github-actions bot commented Nov 15, 2023

Backend Unit Tests Coverage Report

github-actions bot commented Nov 15, 2023

E2E Workflow Workers Coverage Report

github-actions bot commented Nov 15, 2023

E2E Queue Consumers Coverage Report

github-actions bot commented Nov 15, 2023

E2E SIMS API Coverage Report

andrewsignori-aot left a comment

Choose a reason for hiding this comment

guru-aot commented Nov 8, 2023 •

edited

Loading