Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2087 - Ministry Add New Note for Institution Account #2475

Merged
merged 1 commit into from
Nov 3, 2023
Merged

#2087 - Ministry Add New Note for Institution Account #2475

merged 1 commit into from
Nov 3, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Nov 3, 2023 •
edited
Loading

  • Create new note button was missing in the institution note, fixed the issue.
    image
    image
    image

@ann-aot ann-aot self-assigned this Nov 3, 2023
@ann-aot ann-aot added Bug Something isn't working Ministry Ministry Features Web Portal labels Nov 3, 2023
@ann-aot ann-aot requested a review from sh16011993 November 3, 2023 19:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.17% ( 2341 / 12882 )
Methods: 9.28% ( 151 / 1628 )
Lines: 20.69% ( 2016 / 9744 )
Branches: 11.52% ( 174 / 1510 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.53% ( 4084 / 7354 )
Methods: 52.88% ( 505 / 955 )
Lines: 60.25% ( 3310 / 5494 )
Branches: 29.72% ( 269 / 905 )

andrepestana-aot
andrepestana-aot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sh16011993
sh16011993 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @ann-aot

dheepak-aot
dheepak-aot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewsignori-aot
andrewsignori-aot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ann-aot ann-aot merged commit e20534e into main Nov 3, 2023
@ann-aot ann-aot deleted the bug/sims-#2087 branch November 3, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@cditcher cditcher Awaiting requested review from cditcher

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
Bug Something isn't working Ministry Ministry Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ann-aot @sh16011993 @dheepak-aot @andrewsignori-aot @guru-aot @andrepestana-aot