#2322 - IER12 E2E Tests Additional Scenarios #2474
Conversation
andrewsignori-aot
requested review from
guru-aot,
dheepak-aot,
ann-aot,
andrepestana-aot,
sh16011993,
cditcher and
JasonCTang
| const [errorCode] = FULL_TIME_DISBURSEMENT_FEEDBACK_ERRORS; | ||
| const [disbursementSchedule] = | ||
| application.currentAssessment.disbursementSchedules; | ||
| const feedbackError = createDisbursementFeedbackError( |
There was a problem hiding this comment.
Minor. Should we follow the naming convention of createFake*?
| // Queued job. | ||
| // No date provided as it is expected that the disbursement feedback error | ||
| // date would ensure the IER12 record is generated. | ||
| const job = createIER12SchedulerJobMock(); |
There was a problem hiding this comment.
IER here is running based on current date -1 and picking the IER record based on feedback error table.
Amazing to see this level of validation in E2E ❤️
| @@ -50,6 +50,11 @@ export function getUploadedFile( | |||
| sshClientMock: DeepMocked<Client>, | |||
| ): UploadedFile { | |||
| const uploadedFile = {} as UploadedFile; | |||
| if (!sshClientMock.put.mock.calls.length) { | |||
| throw new Error( | |||
| const startDate = new Date(date); | ||
| startDate.setHours(0, 0, 0, 0); | ||
| const endDate = addDays(1, startDate); | ||
| return And(MoreThanOrEqual(startDate), LessThan(endDate)); |
Yes, the idea is still the same: try to finish what we can inside the sprint. I will take this scenario as a priority for the upcoming PR 😉 |
| @@ -50,6 +50,11 @@ export function getUploadedFile( | |||
| sshClientMock: DeepMocked<Client>, | |||
| ): UploadedFile { | |||
There was a problem hiding this comment.
Not a part of this PR but maybe we can update the comment to: "Get the parameters provided to the put method of the SSH client that represents the remote file path and the data that would be uploaded to the SFTP in a real scenario."
| @@ -217,10 +220,8 @@ describe(describeProcessorRootTest(QueueNames.IER12Integration), () => { | |||
|
|
|||
| // Act | |||
| const ier12Results = await processor.processIER12File(job); | |||
| db.application.createQueryBuilder(); | |||
|
Kudos, SonarCloud Quality Gate passed!
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Backend Unit Tests Coverage Report
|
andrewsignori-aot
deleted the
feature/#2322-ier12-e2e-tests-additional-scenarios
branch
Created two more scenarios from the previous PR (#2322 - IER12 E2E Tests - First scenarios #2461) to-do list.
The first E2E above is invoking the processor without specifying the date as per previous PR comment.
New E2E factory created
createDisbursementFeedbackError.Added an exception in case
getUploadedFilewas invoked but it was never called. The tests were failing with a not-so-clear error.Fixed an error in the IER12 query
BETWEENoperator and removed a code TODO.