#2382 - Redis recovery command #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
requested review from
cditcher,
dheepak-aot,
andrewsignori-aot,
ann-aot,
andrepestana-aot,
JasonCTang and
sh16011993
dheepak-aot
approved these changes
Nov 1, 2023
.github/workflows/redis-recovery.yml
Outdated
| steps: | ||
| - name: Print env | ||
| run: | | ||
| echo NAMESPACE: $NAMESPACE |
There was a problem hiding this comment.
GitHub will not print a value that came from a secret so there is no point in printing it, IMO.
.github/workflows/redis-recovery.yml
Outdated
| ref: ${{ inputs.gitRef }} | ||
| - name: Log in to OpenShift | ||
| run: | | ||
| oc login --token=${{ secrets.SA_TOKEN }} --server=https://api.silver.devops.gov.bc.ca:6443 |
There was a problem hiding this comment.
Please use the below instead.
oc login --token=${{ secrets.SA_TOKEN }} --server=${{ vars.OPENSHIFT_CLUSTER_URL }}
.github/workflows/redis-recovery.yml
Outdated
There was a problem hiding this comment.
Every GitHub action is "categorized" as "env-setup" or "release" which adds a prefix to the file name and to the name itself.
Can we rename this file to env-setup-redis-recovery.yml and the name to Env Setup - Redis recovery in Openshift
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
Backend Unit Tests Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a make command from the below recommendation from the Redis channel in rocket chat and it seems to recover our Redis without deleting it completely in the environment and creating them again.
Note: This command had to be run every time, when we put down the Redis manually or any disruptions that restart the Redis pods. Parallel to this, if we have a Sysdig alert which checks the health of the Redis pods in the environment, would help us in any delays to the application queues processing.
Also wiki has been appropriately updated
https://github.com/bcgov/SIMS/wiki/DevOps-and-Running-the-Application#redis-cluster-failing-to-recover