Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2102 - Establishing independent status for Youth in care students #2464

Merged
merged 4 commits into from
Nov 1, 2023
Merged

#2102 - Establishing independent status for Youth in care students #2464

merged 4 commits into from
Nov 1, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Oct 31, 2023 •
edited
Loading

  • Updated current youth in care qn with new qn with tooltip
    image
  • when "yes" is selected for the parent qn, then a subquestion will appear (it also has a tooltip),
    image
  • When the student selects "yes" for the subquestion, consider the student as "independent", (that means, they won't have a parent tab)
  • case 1
    image
    image
    image
    image
  • case 2
    image
    image
    image
    image
  • case 3
    image
    image
    image
    image
  • Updated the showParentInformation logic in forms, which is used to determine the dependant status in the form, which is used in workflow
  • As part of this ticket, there are no Camunda updates.
  • The parent qn (youthInCare) is still used in the fulltime-assessment for below logic,
    image

@ann-aot ann-aot marked this pull request as ready for review October 31, 2023 23:22
@ann-aot ann-aot self-assigned this Oct 31, 2023
@ann-aot ann-aot added the Form.io Form IO definitions changed. label Oct 31, 2023
andrewsignori-aot
andrewsignori-aot reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and analysis. Just minor comments 😉

dheepak-aot
dheepak-aot reviewed Nov 1, 2023
View reviewed changes
sources/packages/forms/src/form-definitions/sfaa2021-22.json
@@ -15531,7 +15595,7 @@
"encrypted": false,
"redrawOn": "data",
"customDefaultValue": "",
"calculateValue": "if (data.hasDependents === 'no' && (data.relationshipStatus === 'single') && data.outOfHighSchoolFor4Years === 'no' && data.howWillYouBeAttendingTheProgram === \"Full Time\") {\n instance.setValue (true);\n}\nelse {\n instance.setValue (false);\n}",
"calculateValue": "if (\r\n data.hasDependents === \"no\" &&\r\n data.relationshipStatus === \"single\" &&\r\n data.outOfHighSchoolFor4Years === \"no\" &&\r\n data.howWillYouBeAttendingTheProgram === \"Full Time\" &&\r\n !(data.everInCustodyOfChildWelfare === \"yes\")\r\n) {\r\n instance.setValue(true);\r\n} else {\r\n instance.setValue(false);\r\n}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. I see a warning in form editor.
image

we can use data.everInCustodyOfChildWelfare !== "yes" instead

dheepak-aot
dheepak-aot reviewed Nov 1, 2023
View reviewed changes
sources/packages/forms/src/form-definitions/sfaa2021-22.json
},
{
"label": "<strong>Were you ever a youth in continuing care or custody of a director of child welfare in BC (ward of the court – this means the provincial government is/was your legal guardian)? </strong>",
"label": "<strong>Were you ever considered a child or youth under government care?</strong>",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stating the workflow reference in the PR description.

image

I have a question here to business.

Should the condition in workflow change from studentDataYouthInCare === "yes" to (studentDataYouthInCare === "yes" && studentDataEverInCustodyOfChildWelfare === "yes") ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, as mentioned in the PR description, for the above logics, the parent question is to be considered,, That's what Hugh told me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @HRAGANBC during development and the studentDataEverInCustodyOfChildWelfare should not affect the workflow. The checks still must happen based on studentDataYouthInCare.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification

@dheepak-aot
Copy link
Collaborator

Good work @ann-aot . Just 2 comments.

sh16011993
sh16011993 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ann-aot 👍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.18% ( 2341 / 12879 )
Methods: 9.28% ( 151 / 1628 )
Lines: 20.7% ( 2016 / 9741 )
Branches: 11.52% ( 174 / 1510 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.59% ( 4088 / 7354 )
Methods: 52.88% ( 505 / 955 )
Lines: 60.3% ( 3313 / 5494 )
Branches: 29.83% ( 270 / 905 )

dheepak-aot
dheepak-aot approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change 👍

andrewsignori-aot
andrewsignori-aot approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes @ann-aot even the minor ones, looks good 👍

andrepestana-aot
andrepestana-aot approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good job!

guru-aot
guru-aot approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ann-aot

@ann-aot ann-aot merged commit 217acbd into main Nov 1, 2023
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:07 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:07 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:07 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:07 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:09 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV November 2, 2023 00:09 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#2102 branch November 3, 2023 21:59
@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Nov 9, 2023 •
edited
Loading

Open Requirement in TestQuality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@cditcher cditcher Awaiting requested review from cditcher

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
Form.io Form IO definitions changed. TestQuality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ann-aot @dheepak-aot @Joshua-Lakusta @sh16011993 @andrewsignori-aot @guru-aot @andrepestana-aot