-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2102 - Establishing independent status for Youth in care students #2464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and analysis. Just minor comments 😉
@@ -15531,7 +15595,7 @@ | |||
"encrypted": false, | |||
"redrawOn": "data", | |||
"customDefaultValue": "", | |||
"calculateValue": "if (data.hasDependents === 'no' && (data.relationshipStatus === 'single') && data.outOfHighSchoolFor4Years === 'no' && data.howWillYouBeAttendingTheProgram === \"Full Time\") {\n instance.setValue (true);\n}\nelse {\n instance.setValue (false);\n}", | |||
"calculateValue": "if (\r\n data.hasDependents === \"no\" &&\r\n data.relationshipStatus === \"single\" &&\r\n data.outOfHighSchoolFor4Years === \"no\" &&\r\n data.howWillYouBeAttendingTheProgram === \"Full Time\" &&\r\n !(data.everInCustodyOfChildWelfare === \"yes\")\r\n) {\r\n instance.setValue(true);\r\n} else {\r\n instance.setValue(false);\r\n}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
{ | ||
"label": "<strong>Were you ever a youth in continuing care or custody of a director of child welfare in BC (ward of the court – this means the provincial government is/was your legal guardian)? </strong>", | ||
"label": "<strong>Were you ever considered a child or youth under government care?</strong>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, as mentioned in the PR description, for the above logics, the parent question is to be considered,, That's what Hugh told me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with @HRAGANBC during development and the studentDataEverInCustodyOfChildWelfare
should not affect the workflow. The checks still must happen based on studentDataYouthInCare
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification
Good work @ann-aot . Just 2 comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ann-aot 👍
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes @ann-aot even the minor ones, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @ann-aot
showParentInformation
logic in forms, which is used to determine thedependant status
in the form, which is used in workflow