Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2147 - Student Application Updates: PD/ PPD Form Update on application #2457

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Oct 24, 2023

  • Added new section and question in the application forms,
    image
  • When option one is selected, the below info banner is shown,
    image
    image
  • When one is selected the student is assessed for PD/PPD
    image
    image
    -When options 2 and 3 are selected, the student is assessed as normal
    image
    image
    image
    image
  • Removed studentPDStatus variable and added studentDataApplicationPDPPDStatus. the calculated result is stored in calculatedDataApplicationPDPPDStatus which is used for both Part-time and Full-time logic in Camunda.
    Part-time
    image
    Full-time
    image

NOTE:
You will see more changes in sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn and sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2022-2023.bpmn, Because it was not updated.

@ann-aot ann-aot marked this pull request as draft October 24, 2023 22:04
@ann-aot ann-aot marked this pull request as ready for review October 25, 2023 18:42
@@ -607,15 +607,15 @@
<bpmn:sequenceFlow id="Flow_1eulup9" sourceRef="Event_1sg75ph" targetRef="Activity_1wciqrl" />
<bpmn:sequenceFlow id="Flow_1lihxee" sourceRef="Gateway_16zyh99" targetRef="Gateway_0rn7rsj" />
<bpmn:sequenceFlow id="Flow_0jvb1k3" name="Exempt" sourceRef="Gateway_0rn7rsj" targetRef="Event_0sz9je4">
<bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or studentPDStatus = true or calculatedDataTotalEligibleDependants &gt; 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression>
<bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or calculatedDataApplicationPDPPDStatus = true or calculatedDataTotalEligibleDependants &gt; 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to share with DEVs, the idea of having the calculatedDataApplicationPDPPDStatus instead of using the applicationPDPPDStatus is to keep it as a boolean (that is what is needed right now) and it would also allow further logic to be introduced when we will need to deal with the PD expiration in the near future.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please take a look at the comments.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.18% ( 2341 / 12879 )
Methods: 9.28% ( 151 / 1628 )
Lines: 20.7% ( 2016 / 9741 )
Branches: 11.52% ( 174 / 1510 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 75.72% ( 555 / 733 )
Methods: 69.32% ( 61 / 88 )
Lines: 77.64% ( 486 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.59% ( 4088 / 7354 )
Methods: 52.88% ( 505 / 955 )
Lines: 60.3% ( 3313 / 5494 )
Branches: 29.83% ( 270 / 905 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, looks good 👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 @ann-aot . Thank You for the walkthrough.

@@ -36,9 +36,9 @@
<zeebe:header key="studentDataVoluntaryContributions" value="$.data.parentvoluntarycontributionsCosts" />
<zeebe:header key="studentDataScholarshipAmount" value="$.data.scholarshipsreceviedCosts" />
<zeebe:header key="studentDataYouthInCare" value="$.data.youthInCare" />
<zeebe:header key="studentDataApplicationPDPPDStatus" value="$.data.applicationPDPPDStatus" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ann-aot. LGTM

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 👍

@ann-aot ann-aot merged commit 4977cf7 into main Oct 25, 2023
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:50 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:51 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:51 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:51 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:54 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 25, 2023 23:54 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#2147 branch October 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants