#2147 - Student Application Updates: PD/ PPD Form Update on application #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann-aot
requested review from
andrewsignori-aot,
dheepak-aot,
sh16011993,
cditcher,
guru-aot,
andrepestana-aot and
JasonCTang
...4/fulltime-assessment/eligibility/fulltime-assessment-2023-2024-eligibility-BGPD.e2e-spec.ts
Show resolved
Hide resolved
| @@ -607,15 +607,15 @@ | |||
| <bpmn:sequenceFlow id="Flow_1eulup9" sourceRef="Event_1sg75ph" targetRef="Activity_1wciqrl" /> | |||
| <bpmn:sequenceFlow id="Flow_1lihxee" sourceRef="Gateway_16zyh99" targetRef="Gateway_0rn7rsj" /> | |||
| <bpmn:sequenceFlow id="Flow_0jvb1k3" name="Exempt" sourceRef="Gateway_0rn7rsj" targetRef="Event_0sz9je4"> | |||
| <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or studentPDStatus = true or calculatedDataTotalEligibleDependants > 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression> | |||
| <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or calculatedDataApplicationPDPPDStatus = true or calculatedDataTotalEligibleDependants > 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression> | |||
There was a problem hiding this comment.
Just to share with DEVs, the idea of having the calculatedDataApplicationPDPPDStatus instead of using the applicationPDPPDStatus is to keep it as a boolean (that is what is needed right now) and it would also allow further logic to be introduced when we will need to deal with the PD expiration in the near future.
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Oct 25, 2023
sh16011993
approved these changes
Oct 25, 2023
dheepak-aot
reviewed
Oct 25, 2023
| @@ -36,9 +36,9 @@ | |||
| <zeebe:header key="studentDataVoluntaryContributions" value="$.data.parentvoluntarycontributionsCosts" /> | |||
| <zeebe:header key="studentDataScholarshipAmount" value="$.data.scholarshipsreceviedCosts" /> | |||
| <zeebe:header key="studentDataYouthInCare" value="$.data.youthInCare" /> | |||
| <zeebe:header key="studentDataApplicationPDPPDStatus" value="$.data.applicationPDPPDStatus" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-When options 2 and 3 are selected, the student is assessed as normal
studentPDStatusvariable and addedstudentDataApplicationPDPPDStatus. the calculated result is stored incalculatedDataApplicationPDPPDStatuswhich is used for both Part-time and Full-time logic in Camunda.Part-time
Full-time
NOTE:
You will see more changes in
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmnandsources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2022-2023.bpmn, Because it was not updated.