-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2147 - Student Application Updates: PD/ PPD Form Update on application #2457
Conversation
...4/fulltime-assessment/eligibility/fulltime-assessment-2023-2024-eligibility-BGPD.e2e-spec.ts
Show resolved
Hide resolved
@@ -607,15 +607,15 @@ | |||
<bpmn:sequenceFlow id="Flow_1eulup9" sourceRef="Event_1sg75ph" targetRef="Activity_1wciqrl" /> | |||
<bpmn:sequenceFlow id="Flow_1lihxee" sourceRef="Gateway_16zyh99" targetRef="Gateway_0rn7rsj" /> | |||
<bpmn:sequenceFlow id="Flow_0jvb1k3" name="Exempt" sourceRef="Gateway_0rn7rsj" targetRef="Event_0sz9je4"> | |||
<bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or studentPDStatus = true or calculatedDataTotalEligibleDependants > 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression> | |||
<bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=studentDataIndigenousStatus = "yes" or calculatedDataApplicationPDPPDStatus = true or calculatedDataTotalEligibleDependants > 0 or studentDataYouthInCare = "yes"</bpmn:conditionExpression> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to share with DEVs, the idea of having the calculatedDataApplicationPDPPDStatus
instead of using the applicationPDPPDStatus
is to keep it as a boolean (that is what is needed right now) and it would also allow further logic to be introduced when we will need to deal with the PD expiration in the near future.
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, please take a look at the comments.
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 @ann-aot . Thank You for the walkthrough.
@@ -36,9 +36,9 @@ | |||
<zeebe:header key="studentDataVoluntaryContributions" value="$.data.parentvoluntarycontributionsCosts" /> | |||
<zeebe:header key="studentDataScholarshipAmount" value="$.data.scholarshipsreceviedCosts" /> | |||
<zeebe:header key="studentDataYouthInCare" value="$.data.youthInCare" /> | |||
<zeebe:header key="studentDataApplicationPDPPDStatus" value="$.data.applicationPDPPDStatus" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ann-aot. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 👍
-When options 2 and 3 are selected, the student is assessed as normal
studentPDStatus
variable and addedstudentDataApplicationPDPPDStatus
. the calculated result is stored incalculatedDataApplicationPDPPDStatus
which is used for both Part-time and Full-time logic in Camunda.Part-time
Full-time
NOTE:
You will see more changes in
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
andsources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2022-2023.bpmn
, Because it was not updated.