#2089 - Upgrade node version on all environments #2448

andrepestana-aot · 2023-10-20T18:28:08Z

Upgraded Dockerfile base images to nodejs-18:1-71.1697652955.
Upgraded Dockerfile.dev base images to node:18.17.1-alpine3.18.
Upgraded ssh2-sftp-client to the latest version.
Did some smoke tests locally to check any incompatibility.

Upgrade local

Please upgrade your local NodeJS version from https://nodejs.org/en/download and check if you are really using the new version:

$ node -v

Current LTS

Just for reference, you can check nodejs' schedule for maintenance.

New features

You can check out the new features here.

…o ubi8 node version; upgraded sftp pkg;

sonarqubecloud · 2023-10-20T23:35:24Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-10-20T23:36:44Z

Backend Unit Tests Coverage Report

Totals
Statements:	18.18% ( 2341 / 12877 )
Methods:	9.28% ( 151 / 1628 )
Lines:	20.7% ( 2016 / 9740 )
Branches:	11.53% ( 174 / 1509 )

github-actions · 2023-10-20T23:37:39Z

E2E Queue Consumers Coverage Report

Totals
Statements:	75.72% ( 555 / 733 )
Methods:	69.32% ( 61 / 88 )
Lines:	77.64% ( 486 / 626 )
Branches:	42.11% ( 8 / 19 )

github-actions · 2023-10-20T23:37:42Z

E2E Workflow Workers Coverage Report

Totals
Statements:	52.62% ( 341 / 648 )
Methods:	50% ( 40 / 80 )
Lines:	56.85% ( 282 / 496 )
Branches:	26.39% ( 19 / 72 )

github-actions · 2023-10-20T23:44:53Z

E2E SIMS API Coverage Report

Totals
Statements:	55.6% ( 4088 / 7352 )
Methods:	52.88% ( 505 / 955 )
Lines:	60.31% ( 3313 / 5493 )
Branches:	29.87% ( 270 / 904 )

dheepak-aot · 2023-10-23T17:26:57Z

devops/Makefile

@@ -231,31 +231,31 @@ build-db-migrations:
 	test -n "$(BUILD_REF)"
 	test -n "$(DB_MIGRATIONS_BUILD_REF)"
 	@echo "+\n++ BUILDING DB migrations with tag: $(BUILD_REF)\n+"
-	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/db-migrations/Dockerfile -p NAME=$(DB_MIGRATIONS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -
+	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-18" -p BASE_IMAGE_TAG="1-71.1697652955" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/db-migrations/Dockerfile -p NAME=$(DB_MIGRATIONS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -


Why can't we use tag 1 like before? they point to same version

This tag is recommended by RedHat:

Version 1-15 (from a year ago):

Compared to 1-71.1697652955 (latest):

1-71 tag has 12 important security adivisories:

Isn't 1-71.1697652955 | latest | 1 the same? I was trying to say we can use 1 instead of the long version 1-71.1697652955 and also I believe 1 must hold latest stable version of the node-18 image.

Correct me if wrong.

Holding the latest stable version would be good but that must happen manually and it must be under our control, that is the same reason that we do not use latest all around 😉

OK, after our talk I got what you mean. Well, ,we can use tag 1 and that would get the latest version for major version 1.
Before we were using version 1-5 and that one doesn't point to any latest version.
@andrewsignori-aot @guru-aot @ann-aot @cditcher What do you guys suggest? Use 1 to always get the latest version or have a fixed tagged version?

dheepak-aot · 2023-10-23T17:27:19Z

devops/Makefile

 	@oc -n $(BUILD_NAMESPACE) start-build bc/$(DB_MIGRATIONS_BUILD_REF) --wait

 build-api:
 	test -n "$(BUILD_NAMESPACE)"
 	test -n "$(BUILD_REF)"
 	test -n "$(API_BUILD_REF)"
 	@echo "+\n++ BUILDING API with tag: $(BUILD_REF)\n+"
-	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/api/Dockerfile -p NAME=$(API_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -
+	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-18" -p BASE_IMAGE_TAG="1-71.1697652955" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/api/Dockerfile -p NAME=$(API_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -


https://github.com/bcgov/SIMS/pull/2448/files#r1369020570

https://github.com/bcgov/SIMS/pull/2448/files#r1369096136

dheepak-aot · 2023-10-23T17:27:26Z

devops/Makefile

 	@oc -n $(BUILD_NAMESPACE) start-build bc/$(API_BUILD_REF) --wait

 build-workers:
 	test -n "$(BUILD_NAMESPACE)"
 	test -n "$(BUILD_REF)"
 	test -n "$(WORKERS_BUILD_REF)"
 	@echo "+\n++ BUILDING WORKERS with tag: $(BUILD_REF)\n+"
-	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/workers/Dockerfile -p NAME=$(WORKERS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -
+	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-18" -p BASE_IMAGE_TAG="1-71.1697652955" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/workers/Dockerfile -p NAME=$(WORKERS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -


https://github.com/bcgov/SIMS/pull/2448/files#r1369020570

https://github.com/bcgov/SIMS/pull/2448/files#r1369096136

dheepak-aot · 2023-10-23T17:50:42Z

sources/packages/backend/apps/api/Dockerfile

@@ -1,5 +1,5 @@
 # Base Image
-FROM artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/nodejs-16:1-5
+FROM artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/nodejs-18:1-71.1697652955


https://github.com/bcgov/SIMS/pull/2448/files#r1369020570

In other dockerfile as well

https://github.com/bcgov/SIMS/pull/2448/files#r1369096136

sources/packages/web/Dockerfile

dheepak-aot · 2023-10-23T18:06:56Z

sources/packages/web/Dockerfile.dev

@@ -1,5 +1,5 @@
 # "builder" stage, based on Node.js, to build and compile the frontend.
-FROM node:16.17.0-alpine3.16 AS builder
+FROM node:18.17.1-alpine3.18 AS builder


Question to devs. Shouldn't we change the local docker for web to nginx?

@andrewsignori-aot @ann-aot @guru-aot @cditcher ?

nginx:122 doesn't have npm:

Im good.

#2448 (comment)

dheepak-aot · 2023-10-23T18:07:34Z

Nice work @andrepestana-aot 👍Added some comments.

andrewsignori-aot · 2023-10-23T20:26:40Z

devops/Makefile

@@ -231,31 +231,31 @@ build-db-migrations:
 	test -n "$(BUILD_REF)"
 	test -n "$(DB_MIGRATIONS_BUILD_REF)"
 	@echo "+\n++ BUILDING DB migrations with tag: $(BUILD_REF)\n+"
-	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/db-migrations/Dockerfile -p NAME=$(DB_MIGRATIONS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -
+	@oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-18" -p BASE_IMAGE_TAG="1-71.1697652955" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/db-migrations/Dockerfile -p NAME=$(DB_MIGRATIONS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f -


Can we have a ticket to check if we can remove the BASE_IMAGE_NAME and BASE_IMAGE_TAG from the make file? The idea would be to stop updating the image version in two places. If there is a benefit in the way as it is right now, please share 😉
@guru-aot @dheepak-aot @ann-aot FYI

Sure, as I was having a look on it, we use the BASE_IMAGE_NAME and BASE_IMAGE_TAG as metadata while building and for tag name. We can do a deep analysis and can remove it.

@guru-aot can you please post here for history when those metadas are displayed in OpenShift?

I created a ticket: https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2453

andrewsignori-aot

Nice work, looks good 👍

guru-aot

LGTM, nice work @andrepestana-aot

ann-aot

Nice work @andrepestana-aot 👍

dheepak-aot

Looks good 👍

andrepestana-aot added 2 commits October 20, 2023 11:26

initial commit

e45a35f

upgraded ubi8 image to most recent; changed alpine to be compatible t…

b02a109

…o ubi8 node version; upgraded sftp pkg;

andrepestana-aot requested review from dheepak-aot and andrewsignori-aot October 23, 2023 16:41

andrepestana-aot marked this pull request as ready for review October 23, 2023 16:41

andrepestana-aot requested review from ann-aot, guru-aot and JasonCTang October 23, 2023 16:43

andrepestana-aot self-assigned this Oct 23, 2023

andrepestana-aot added the Task label Oct 23, 2023

dheepak-aot reviewed Oct 23, 2023

View reviewed changes

sources/packages/web/Dockerfile Show resolved Hide resolved

dheepak-aot reviewed Oct 23, 2023

View reviewed changes

andrewsignori-aot reviewed Oct 23, 2023

View reviewed changes

andrewsignori-aot approved these changes Oct 23, 2023

View reviewed changes

guru-aot approved these changes Oct 23, 2023

View reviewed changes

ann-aot approved these changes Oct 23, 2023

View reviewed changes

dheepak-aot approved these changes Oct 23, 2023

View reviewed changes

andrepestana-aot merged commit 5da7fc9 into main Oct 23, 2023

andrepestana-aot deleted the 2089_upgrade_node_version branch October 23, 2023 23:56

andrepestana-aot temporarily deployed to DEV October 24, 2023 00:10 — with GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV October 24, 2023 00:11 — with GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV October 24, 2023 00:14 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2089 - Upgrade node version on all environments #2448

#2089 - Upgrade node version on all environments #2448

andrepestana-aot commented Oct 20, 2023 •

edited

Loading

sonarqubecloud bot commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

dheepak-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023 •

edited

Loading

andrewsignori-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023 •

edited

Loading

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

dheepak-aot Oct 23, 2023

dheepak-aot commented Oct 23, 2023

andrewsignori-aot Oct 23, 2023

guru-aot Oct 23, 2023

andrewsignori-aot Oct 23, 2023

andrepestana-aot Oct 23, 2023

andrewsignori-aot left a comment

guru-aot left a comment

ann-aot left a comment

dheepak-aot left a comment

#2089 - Upgrade node version on all environments #2448

#2089 - Upgrade node version on all environments #2448

Conversation

andrepestana-aot commented Oct 20, 2023 • edited Loading

Upgrade local

Current LTS

New features

sonarqubecloud bot commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

Backend Unit Tests Coverage Report

github-actions bot commented Oct 20, 2023

E2E Queue Consumers Coverage Report

github-actions bot commented Oct 20, 2023

E2E Workflow Workers Coverage Report

github-actions bot commented Oct 20, 2023

E2E SIMS API Coverage Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot Oct 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot Oct 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot commented Oct 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsignori-aot left a comment

Choose a reason for hiding this comment

guru-aot left a comment

Choose a reason for hiding this comment

ann-aot left a comment

Choose a reason for hiding this comment

dheepak-aot left a comment

Choose a reason for hiding this comment

andrepestana-aot commented Oct 20, 2023 •

edited

Loading

dheepak-aot Oct 23, 2023 •

edited

Loading

dheepak-aot Oct 23, 2023 •

edited

Loading