Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2289 - Implement logic for Application Event Code in IER12 - code and date assignment (Part 5) #2443

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Oct 19, 2023

  • There was a logic missing for application event code and date, due to which both fields were not showing in the file content
    Sample file screenshot
    image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 18.18% ( 2341 / 12877 )
Methods: 9.28% ( 151 / 1628 )
Lines: 20.7% ( 2016 / 9740 )
Branches: 11.53% ( 174 / 1509 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 75.72% ( 555 / 733 )
Methods: 69.32% ( 61 / 88 )
Lines: 77.64% ( 486 / 626 )
Branches: 42.11% ( 8 / 19 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ann-aot

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.18% ( 4057 / 7352 )
Methods: 52.25% ( 499 / 955 )
Lines: 59.95% ( 3293 / 5493 )
Branches: 29.31% ( 265 / 904 )

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ann-aot ann-aot merged commit c63d07a into main Oct 19, 2023
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 16:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 16:59 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 16:59 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 16:59 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 16:59 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 17:02 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV October 19, 2023 17:02 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#2289-part-5 branch October 19, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants