Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2410 - E2E Test - Assessment workers #2423

Merged
merged 9 commits into from
Oct 18, 2023

Conversation

andrepestana-aot
Copy link
Collaborator

Created a simple E2E test for

  • saveAssessmentData.
  • updateNOAStatus.
  • workflowWrapUp.

@andrepestana-aot andrepestana-aot changed the title E22 Test - assessment workers E2E Test - Assessment workers Oct 17, 2023
@andrepestana-aot andrepestana-aot self-assigned this Oct 17, 2023
@andrepestana-aot andrepestana-aot added Test Case tickets relating to test cases E2E/Unit tests labels Oct 17, 2023
@andrepestana-aot andrepestana-aot marked this pull request as ready for review October 17, 2023 16:22
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, please take a look at the comments.

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments 👍

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, looks good 👍

@dheepak-aot
Copy link
Collaborator

Nice work @andrepestana-aot . Please have a look at the comments.

const assessmentData = { totalAssessmentNeed: 9999 };

// Act
const result = await assessmentController.saveAssessmentData(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

E2EDataSources,
saveFakeApplication,
} from "@sims/test-utils";
import { ICustomHeaders, IOutputVariables } from "zeebe-node";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are a few unused imports.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.22% ( 2219 / 12884 )
Methods: 7.92% ( 129 / 1629 )
Lines: 19.97% ( 1946 / 9746 )
Branches: 9.54% ( 144 / 1509 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 75.72% ( 555 / 733 )
Methods: 69.32% ( 61 / 88 )
Lines: 77.64% ( 486 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.18% ( 4057 / 7352 )
Methods: 52.25% ( 499 / 955 )
Lines: 59.95% ( 3293 / 5493 )
Branches: 29.31% ( 265 / 904 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks Good

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @andrepestana-aot 👍 Thanks for explaining my doubts.

@andrepestana-aot andrepestana-aot merged commit 0e8e2c3 into main Oct 18, 2023
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:04 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:06 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:06 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:06 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:06 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:13 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV October 18, 2023 20:13 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot deleted the e2e_tests_assessment_workers branch October 18, 2023 20:57
@andrepestana-aot andrepestana-aot changed the title E2E Test - Assessment workers #2410 - E2E Test - Assessment workers Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E/Unit tests Test Case tickets relating to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants