-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2410 - E2E Test - Assessment workers #2423
Conversation
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Show resolved
Hide resolved
...packages/backend/apps/workers/src/controllers/assessment/_tests_/e2e/save-assessment-data.ts
Outdated
Show resolved
Hide resolved
...es/packages/backend/apps/workers/src/controllers/assessment/_tests_/e2e/update-noa-status.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, please take a look at the comments.
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../backend/apps/workers/src/controllers/assessment/_tests_/e2e/save-assessment-data-factory.ts
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes, looks good 👍
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Show resolved
Hide resolved
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
Nice work @andrepestana-aot . Please have a look at the comments. |
const assessmentData = { totalAssessmentNeed: 9999 }; | ||
|
||
// Act | ||
const result = await assessmentController.saveAssessmentData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
E2EDataSources, | ||
saveFakeApplication, | ||
} from "@sims/test-utils"; | ||
import { ICustomHeaders, IOutputVariables } from "zeebe-node"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are a few unused imports.
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Looks Good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @andrepestana-aot 👍 Thanks for explaining my doubts.
Created a simple E2E test for