#2410 - E2E Test - Assessment workers #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepestana-aot
changed the title
andrepestana-aot
requested review from
sh16011993,
dheepak-aot,
andrewsignori-aot,
guru-aot,
ann-aot and
JasonCTang
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Show resolved
Hide resolved
...packages/backend/apps/workers/src/controllers/assessment/_tests_/e2e/save-assessment-data.ts
Outdated
Show resolved
Hide resolved
...es/packages/backend/apps/workers/src/controllers/assessment/_tests_/e2e/update-noa-status.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
.../backend/apps/workers/src/controllers/assessment/_tests_/e2e/save-assessment-data-factory.ts
Show resolved
Hide resolved
ann-aot
reviewed
Oct 17, 2023
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Show resolved
Hide resolved
andrewsignori-aot
approved these changes
Oct 18, 2023
dheepak-aot
reviewed
Oct 18, 2023
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 18, 2023
.../src/controllers/assessment/_tests_/e2e/assessment.controller-saveAssessmentData.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 18, 2023
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 18, 2023
...ers/src/controllers/assessment/_tests_/e2e/assessment.controller-updateNOAStatus.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 18, 2023
...kers/src/controllers/assessment/_tests_/e2e/assessment.controller-workflowWrapUp.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Nice work @andrepestana-aot . Please have a look at the comments. |
sh16011993
reviewed
Oct 18, 2023
| const assessmentData = { totalAssessmentNeed: 9999 }; | ||
|
|
||
| // Act | ||
| const result = await assessmentController.saveAssessmentData( |
sh16011993
reviewed
Oct 18, 2023
| E2EDataSources, | ||
| saveFakeApplication, | ||
| } from "@sims/test-utils"; | ||
| import { ICustomHeaders, IOutputVariables } from "zeebe-node"; |
There was a problem hiding this comment.
I believe there are a few unused imports.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Oct 18, 2023
sh16011993
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Nice work @andrepestana-aot 👍 Thanks for explaining my doubts.
andrepestana-aot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple E2E test for