#2379 - Fix computer multiplication in combine decimal places #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
requested review from
sh16011993,
andrewsignori-aot,
guru-aot,
ann-aot,
andrepestana-aot and
JasonCTang
andrewsignori-aot
approved these changes
Oct 16, 2023
guru-aot
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating point arithmetic issue in programming languages
https://stackoverflow.com/questions/45221535/javascript-floating-point-multiply-by-100-still-has-errors
Issue and fix
Certain decimal numbers when multiplied by 100 may not return precise mathematical result as we expect
Math.round()seems to be one of the solutions to handle this issue.But in the
combineDecimalPlacesmethod we are dividing and then multiplying by 100 again, which re-creates the same issue which was fixed byMath.round()Hence: Divide and multiply of the rounded value by multiplier is removed.
File output