Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2373 - IER fix allow zero grants #2385

Merged
merged 1 commit into from
Oct 5, 2023
Merged

#2373 - IER fix allow zero grants #2385

merged 1 commit into from
Oct 5, 2023

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Oct 5, 2023 •
edited
Loading

IER Fix allow zero grants

  • Add initial value to reduce function
  • Test the fix by creating an application submitted for BC Private (any non BC Public institution) and applicant income as $100000
    image

@dheepak-aot dheepak-aot self-assigned this Oct 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.42% ( 2206 / 12665 )
Methods: 8.08% ( 129 / 1597 )
Lines: 20.16% ( 1933 / 9587 )
Branches: 9.72% ( 144 / 1481 )

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 74.93% ( 514 / 686 )
Methods: 67.47% ( 56 / 83 )
Lines: 76.96% ( 451 / 586 )
Branches: 41.18% ( 7 / 17 )

andrepestana-aot
andrepestana-aot approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrewsignori-aot
andrewsignori-aot approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ann-aot
ann-aot approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sh16011993
sh16011993 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.94% ( 4032 / 7339 )
Methods: 51.99% ( 496 / 954 )
Lines: 59.77% ( 3273 / 5476 )
Branches: 28.93% ( 263 / 909 )

@dheepak-aot dheepak-aot merged commit 479c69c into main Oct 5, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:03 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:04 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:04 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:04 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:04 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:08 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV October 6, 2023 00:08 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the bug/#2373-ier-allow-zero-grants branch October 11, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@guru-aot guru-aot Awaiting requested review from guru-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@dheepak-aot dheepak-aot

Labels
Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dheepak-aot @sh16011993 @andrewsignori-aot @ann-aot @andrepestana-aot