Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2357 - Replace separator component and vertical-divider class with v-divider component #2358

Merged
merged 3 commits into from
Sep 27, 2023
Merged

#2357 - Replace separator component and vertical-divider class with v-divider component #2358

merged 3 commits into from
Sep 27, 2023

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Sep 26, 2023 •
edited
Loading

As a part of this PR, the following tasks were completed:

  • Replace separator component and vertical-divider class with v-divider component

Screenshots:

image image

@sh16011993 sh16011993 self-assigned this Sep 26, 2023
@andrewsignori-aot andrewsignori-aot added the Enhancement New feature or request label Sep 26, 2023
@sh16011993 sh16011993 removed the Enhancement New feature or request label Sep 26, 2023
@sh16011993 sh16011993 removed the request for review from michesmith September 26, 2023 22:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.45% ( 2205 / 12639 )
Methods: 8.1% ( 129 / 1593 )
Lines: 20.19% ( 1932 / 9570 )
Branches: 9.76% ( 144 / 1476 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 74.93% ( 514 / 686 )
Methods: 67.47% ( 56 / 83 )
Lines: 76.96% ( 451 / 586 )
Branches: 41.18% ( 7 / 17 )

ann-aot
ann-aot approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for doing the changes:

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.88% ( 4021 / 7327 )
Methods: 51.89% ( 493 / 950 )
Lines: 59.72% ( 3266 / 5469 )
Branches: 28.85% ( 262 / 908 )

andrewsignori-aot
andrewsignori-aot approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, looks good 👍

dheepak-aot
dheepak-aot approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@sh16011993 sh16011993 merged commit f1bb49e into main Sep 27, 2023
@sh16011993 sh16011993 deleted the 2357_replace_separator_component_with_vdivider branch September 27, 2023 16:15
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:37 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:38 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:41 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV September 27, 2023 16:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@guru-aot guru-aot Awaiting requested review from guru-aot

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@sh16011993 sh16011993

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sh16011993 @dheepak-aot @andrewsignori-aot @ann-aot