Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2137 Full Time Work Question removal from Student application #2333

Merged
merged 1 commit into from
Sep 25, 2023
Merged

#2137 Full Time Work Question removal from Student application #2333

merged 1 commit into from
Sep 25, 2023

Conversation

guru-aot
Copy link
Collaborator

image
Question has been removed and no exception is attached to it , so there are no workflow changes.

@guru-aot guru-aot self-assigned this Sep 25, 2023
@guru-aot guru-aot added the Form.io Form IO definitions changed. label Sep 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.44% ( 2205 / 12641 )
Methods: 8.1% ( 129 / 1593 )
Lines: 20.19% ( 1932 / 9571 )
Branches: 9.75% ( 144 / 1477 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 74.93% ( 514 / 686 )
Methods: 67.47% ( 56 / 83 )
Lines: 76.96% ( 451 / 586 )
Branches: 41.18% ( 7 / 17 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.48% ( 3995 / 7333 )
Methods: 51.31% ( 488 / 951 )
Lines: 59.3% ( 3245 / 5472 )
Branches: 28.79% ( 262 / 910 )

andrewsignori-aot
andrewsignori-aot approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

dheepak-aot
dheepak-aot approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The ticket when I read, was misleading towards exception. Thanks for updating the ticket that there was no exception associated to this question.

andrepestana-aot
andrepestana-aot approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@guru-aot guru-aot merged commit f77ce11 into main Sep 25, 2023
@guru-aot guru-aot deleted the 2137_FullTimeWork_Question_Removal branch September 25, 2023 21:03
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:16 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:19 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:19 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:19 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:19 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:22 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 25, 2023 21:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@ann-aot ann-aot Awaiting requested review from ann-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@guru-aot guru-aot

Labels
Form.io Form IO definitions changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guru-aot @dheepak-aot @andrewsignori-aot @andrepestana-aot