Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2172 - Remove Part-Time Questions from Application #2325

Merged
merged 4 commits into from
Sep 25, 2023
Merged

#2172 - Remove Part-Time Questions from Application #2325

merged 4 commits into from
Sep 25, 2023

Conversation

andrepestana-aot
Copy link
Contributor

@andrepestana-aot andrepestana-aot commented Sep 21, 2023 •
edited
Loading

  • Hid the questions for part-time applications;
  • Tested Part-time and Full-time application.

Part-time test:

image
image
image
image
image

Full-time test:

image
image
image
image
image

@andrepestana-aot andrepestana-aot self-assigned this Sep 21, 2023
@andrepestana-aot andrepestana-aot marked this pull request as ready for review September 21, 2023 23:05
@andrepestana-aot andrepestana-aot added Student Student Features Web Portal Form.io Form IO definitions changed. labels Sep 21, 2023
guru-aot
guru-aot approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

andrewsignori-aot
andrewsignori-aot approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ann-aot
ann-aot approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work @andrepestana-aot

dheepak-aot
dheepak-aot reviewed Sep 22, 2023
View reviewed changes
sources/packages/forms/src/form-definitions/sfaa2021-22.json
"eq": "",
"show": "true",
"when": "howWillYouBeAttendingTheProgram",
"eq": "Full Time",
"json": ""
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see this question in PT application.
image

Is it not the one listed here to be removed ?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done.

sh16011993
sh16011993 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @andrepestana-aot 👍

@dheepak-aot
Copy link
Collaborator

Great job. Just one outstanding comment.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.53% ( 2205 / 12582 )
Methods: 8.13% ( 129 / 1586 )
Lines: 20.29% ( 1932 / 9524 )
Branches: 9.78% ( 144 / 1472 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 74.31% ( 483 / 650 )
Methods: 66.67% ( 54 / 81 )
Lines: 76.4% ( 424 / 555 )
Branches: 35.71% ( 5 / 14 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.48% ( 3995 / 7333 )
Methods: 51.31% ( 488 / 951 )
Lines: 59.3% ( 3245 / 5472 )
Branches: 28.79% ( 262 / 910 )

dheepak-aot
dheepak-aot approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 👍

@andrepestana-aot andrepestana-aot merged commit 05bb0c4 into main Sep 25, 2023
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:35 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:37 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:37 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:37 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:37 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:39 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 25, 2023 17:39 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot deleted the 2172_remove_parttime_questions branch October 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrepestana-aot andrepestana-aot

Labels
Form.io Form IO definitions changed. Student Student Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrepestana-aot @dheepak-aot @sh16011993 @andrewsignori-aot @guru-aot @ann-aot