#2222 - IER 12 Implementation blue fields #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
requested review from
andrepestana-aot,
ann-aot,
guru-aot,
sh16011993,
andrewsignori-aot and
JasonCTang
| @@ -28,8 +29,7 @@ export class IER12FileDetail implements IER12FileLine { | |||
| studentGivenName?: string; | |||
| studentBirthDate: Date; | |||
| studentGroupCode: "A" | "B"; | |||
| // Analysis pending for the field. | |||
| studentMaritalStatusCode?: string; | |||
| studentMaritalStatusCode: "SI" | "SP" | "MA"; | |||
There was a problem hiding this comment.
I was wondering if it wouldn't be better to create a Enum for that.
There was a problem hiding this comment.
I see your point. I was thinking back and forth about creating enum.
Only thing which stopped me from creating enum was, the enum isn't going to be used anywhere like ApplicationStatusCode which was used for a transformation.
Having said that, I can definitely create a type to keep the type creation in one place.
Comment on lines
106
to
108
| UC = "UC", | ||
| EC = "EC", | ||
| CI = "CI", |
There was a problem hiding this comment.
Could you add a comment above the items describing them, please?
...libs/integrations/src/institution-integration/ier12-integration/ier12.integration.service.ts
Show resolved
Hide resolved
sources/packages/backend/workflow/BPMN/camunda-8/assessment-gateway.bpmn
Outdated
Show resolved
Hide resolved
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Sep 20, 2023
...backend/libs/integrations/src/institution-integration/ier12-integration/ier12-file-detail.ts
Show resolved
Hide resolved
ann-aot
reviewed
Sep 20, 2023
...libs/integrations/src/institution-integration/ier12-integration/ier12.integration.service.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Sep 20, 2023
| @@ -120,10 +124,16 @@ export class StudentAssessmentService extends RecordDataModelService<StudentAsse | |||
| { | |||
| assessmentDate: dateEqualTo(processingDate), | |||
| offering: { institutionLocation: { hasIntegration: true } }, | |||
| application: { | |||
| applicationStatus: Not(ApplicationStatus.Overwritten), | |||
ann-aot
reviewed
Sep 20, 2023
.../libs/integrations/src/institution-integration/ier12-integration/ier12.processing.service.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Sep 20, 2023
sources/packages/backend/workflow/BPMN/camunda-8/fulltime-assessment-2021-2022.bpmn
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Sep 20, 2023
guru-aot
reviewed
Sep 20, 2023
| @@ -28,8 +29,7 @@ export class IER12FileDetail implements IER12FileLine { | |||
| studentGivenName?: string; | |||
| studentBirthDate: Date; | |||
| studentGroupCode: "A" | "B"; | |||
| // Analysis pending for the field. | |||
| studentMaritalStatusCode?: string; | |||
| studentMaritalStatusCode: "SI" | "SP" | "MA"; | |||
There was a problem hiding this comment.
can we move this to the ier12-integration-model ?
guru-aot
approved these changes
Sep 20, 2023
andrewsignori-aot
approved these changes
Sep 21, 2023
ann-aot
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Great work @dheepak-aot with the analysis and the implementation
andrepestana-aot
approved these changes
Sep 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IER Implementation of blue fields
Note: Application event code and application event date is not handled in the current ticket as it will be done in seperate ticket.
For reference Please use the spreadsheet from General > Files >Analysis > Institution File Specs > IER12_Analysis_Output_and_Mapping_Part_1_V2_PR.xlsx
from teams.
Mapping has been done for 23 blue fields excluding Application event code and Application event date.
calulatedDataStudentMaritalStatusCode(value has "SI" | "SP" | "MA")calculatedDataDependantTotalMSOLAllowanceupdated
calculatedDataTotalMSOLAllowanceto use the variablecalulatedDataStudentMaritalStatusCodeinstead on doing same calculation again.calaulatedDataTotalNonEducationalCostsUpdated the spreadsheet with details which were discussed during the implementation
In memory calculations were used when the IER field mapping was achievable from existing assessment_data values. We did not create new workflow variables for them.
For e.g.
Few variables which were required for workflow_data were initialized to null in the assessment gateway as they were not guaranteed in all the scenarios.
Added filler for the 10th award slot.
Generated sample file
IER_012_2023-09-19_08.32.57.txt