Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1827 - Change dmn id and requirements #2310

Merged
merged 3 commits into from
Sep 15, 2023
Merged

#1827 - Change dmn id and requirements #2310

merged 3 commits into from
Sep 15, 2023

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Sep 15, 2023 •
edited
Loading

  • Changed dmn id and requirements for dmnPartTimeAssessmentDecisions and dmnFullTimeAssessmentDecisions.
    image

@andrepestana-aot andrepestana-aot self-assigned this Sep 15, 2023
@andrepestana-aot andrepestana-aot added Task Camunda deployment Updates to camunda deployment task labels Sep 15, 2023
andrewsignori-aot
andrewsignori-aot approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.56% ( 2198 / 12520 )
Methods: 8.09% ( 128 / 1583 )
Lines: 20.32% ( 1928 / 9486 )
Branches: 9.79% ( 142 / 1451 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 67.23% ( 437 / 650 )
Methods: 58.02% ( 47 / 81 )
Lines: 69.55% ( 386 / 555 )
Branches: 28.57% ( 4 / 14 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.48% ( 3995 / 7333 )
Methods: 51.31% ( 488 / 951 )
Lines: 59.3% ( 3245 / 5472 )
Branches: 28.79% ( 262 / 910 )

ann-aot
ann-aot approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @andrepestana-aot 👍

guru-aot
guru-aot approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dheepak-aot
dheepak-aot approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@andrepestana-aot andrepestana-aot merged commit 0da64b0 into main Sep 15, 2023
@andrepestana-aot andrepestana-aot deleted the 1827_change_dmn_id branch September 15, 2023 23:22
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:40 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:42 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:42 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:42 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:42 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:44 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 15, 2023 23:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrepestana-aot andrepestana-aot

Labels
Camunda deployment Updates to camunda deployment task Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrepestana-aot @dheepak-aot @andrewsignori-aot @guru-aot @ann-aot