Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2180 - Assessment Workflow Enqueuer Scheduler - Start Assessment (Part 1) - DB migration fix #2290

Merged
merged 1 commit into from
Sep 12, 2023
Merged

#2180 - Assessment Workflow Enqueuer Scheduler - Start Assessment (Part 1) - DB migration fix #2290

merged 1 commit into from
Sep 12, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

A missing CASE condition was causing an attempt to set null the student assessment status: "QueryFailedError: null value in column "student_assessment_status" violates not-null constraint".

@andrewsignori-aot andrewsignori-aot added Bug Something isn't working DB DB migration involved labels Sep 12, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this Sep 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review September 12, 2023 23:08
@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.54% ( 2181 / 12437 )
Methods: 8.02% ( 126 / 1572 )
Lines: 20.32% ( 1917 / 9432 )
Branches: 9.63% ( 138 / 1433 )

dheepak-aot
dheepak-aot approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

guru-aot
guru-aot approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 67.54% ( 437 / 647 )
Methods: 58.02% ( 47 / 81 )
Lines: 69.93% ( 386 / 552 )
Branches: 28.57% ( 4 / 14 )

andrepestana-aot
andrepestana-aot approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 54.48% ( 3995 / 7333 )
Methods: 51.31% ( 488 / 951 )
Lines: 59.3% ( 3245 / 5472 )
Branches: 28.79% ( 262 / 910 )

@andrewsignori-aot andrewsignori-aot merged commit 609c800 into main Sep 12, 2023
@andrewsignori-aot andrewsignori-aot deleted the fix/#2180-db-migration-issue branch September 12, 2023 23:24
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:33 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:35 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:35 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:35 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:35 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:38 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV September 12, 2023 23:38 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@ann-aot ann-aot Awaiting requested review from ann-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Bug Something isn't working DB DB migration involved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewsignori-aot @dheepak-aot @guru-aot @andrepestana-aot