Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2180 - Queued Assessments - Assessment Workflow Enqueuer Scheduler - Start Assessment (Part 1) #2285

Merged
merged 17 commits into from
Sep 12, 2023
Merged

#2180 - Queued Assessments - Assessment Workflow Enqueuer Scheduler - Start Assessment (Part 1) #2285

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
224d811
Starting the workflow on application submission.
andrewsignori-aot Sep 8, 2023
d348b75
Stop calling the queue for features
andrewsignori-aot Sep 8, 2023
9d9497e
DB migration to update student assessment
andrewsignori-aot Sep 8, 2023
a698573
Temporary logs added.
andrewsignori-aot Sep 8, 2023
c6b3aed
Code cleanup
andrewsignori-aot Sep 8, 2023
8842e00
Typeorm DB migration transaction mode changed
andrewsignori-aot Sep 8, 2023
33a9ea9
E2E test fix
andrewsignori-aot Sep 8, 2023
cda732c
E2E test fix
andrewsignori-aot Sep 11, 2023
751b9a5
Pre-review adjustments
andrewsignori-aot Sep 11, 2023
0165fed
Update application/assessment changes.
andrewsignori-aot Sep 11, 2023
df7e3e7
Error improvement
andrewsignori-aot Sep 11, 2023
51248f6
DB migration improvements
andrewsignori-aot Sep 11, 2023
ba0637a
PR comments.
andrewsignori-aot Sep 11, 2023
345050f
PR comments
andrewsignori-aot Sep 12, 2023
a053969
Reverted DB migration transaction mode.
andrewsignori-aot Sep 12, 2023
f5b5579
Removed submitted from DB migration
andrewsignori-aot Sep 12, 2023
c8578d6
Log improvement
andrewsignori-aot Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/packages/backend/apps/db-migrations/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { ormConfig } from "./data-source";
await dataSource.query(`SET search_path TO ${ormConfig.schema}, public;`);
await dataSource.query(`SET SCHEMA '${ormConfig.schema}';`);
console.info(`**** Running migration ****`);
await dataSource.runMigrations({ transaction: "each" });
await dataSource.runMigrations();
console.info(`**** Running setupDB: [Complete] ****`);
} catch (error) {
console.error(`Exception occurs during setup db process: ${error}`);
Expand Down
8 changes: 7 additions & 1 deletion ...ackend/apps/db-migrations/src/sql/StudentAssessments/Update-student-assessment-status.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,10 @@ FROM
sims.applications
WHERE
application_id = sims.applications.id
AND sims.applications.application_status IN ('Cancelled', 'Overwritten')
AND sims.applications.application_status NOT IN (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

'Submitted',
'In Progress',
'Assessment',
'Enrolment',
'Completed'
);