Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1875 - PodDisruptionBudget Bug #2262

Merged
merged 2 commits into from
Sep 5, 2023
Merged

#1875 - PodDisruptionBudget Bug #2262

merged 2 commits into from
Sep 5, 2023

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Sep 5, 2023

Attaching PDB to the statefulset and deploymentconfig

@guru-aot guru-aot added Bug Something isn't working Devops Devops labels Sep 5, 2023
@guru-aot guru-aot self-assigned this Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 46.73% ( 300 / 642 )
Methods: 40% ( 32 / 80 )
Lines: 51.02% ( 251 / 492 )
Branches: 24.29% ( 17 / 70 )

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.94% ( 2177 / 12138 )
Methods: 8.16% ( 126 / 1544 )
Lines: 20.8% ( 1913 / 9195 )
Branches: 9.86% ( 138 / 1399 )

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@andrewsignori-aot andrewsignori-aot changed the title #1875-PodDisruptionBudget_Bug #1875 - PodDisruptionBudget Bug Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 53.27% ( 3931 / 7379 )
Methods: 49.48% ( 472 / 954 )
Lines: 58.32% ( 3210 / 5504 )
Branches: 27.04% ( 249 / 921 )

andrewsignori-aot
andrewsignori-aot approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ann-aot
ann-aot approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guru-aot guru-aot merged commit 2ff172f into main Sep 5, 2023
@guru-aot guru-aot deleted the #1875-PodDisruptionBudget-Bug branch September 5, 2023 17:18
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:29 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:30 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:30 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:30 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:30 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:33 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV September 5, 2023 17:33 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@sh16011993 sh16011993 Awaiting requested review from sh16011993

@dheepak-aot dheepak-aot Awaiting requested review from dheepak-aot

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@guru-aot guru-aot

Labels
Bug Something isn't working Devops Devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guru-aot @andrewsignori-aot @ann-aot