#1970 - File integration - Fix the incorrect line number of detail records #2247
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrepestana-aot
commented
Sep 1, 2023
•
andrepestana-aot
commented
- Changed the code to take into account the header file line number when counting the file content line numbers.
- Fixed broken tests
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
requested review from
andrewsignori-aot,
sh16011993,
guru-aot,
dheepak-aot,
ann-aot and
JasonCTang
and removed request for
sh16011993
ann-aot
reviewed
Sep 1, 2023
| @@ -149,7 +149,7 @@ export class CRAIntegrationService extends SFTPIntegrationBase<CRASFTPResponseFi | |||
| const statusRecords: CRAResponseStatusRecord[] = []; | |||
| const totalIncomeRecords: CRAResponseTotalIncomeRecord[] = []; | |||
| fileLines.forEach((line: string, index: number) => { | |||
| const lineNumber = index + 1; | |||
| const lineNumber = index + 2; // Take into account the removed header line. | |||
There was a problem hiding this comment.
maybe we can move the comment above the line 152. same for other files
ann-aot
approved these changes
Sep 1, 2023
andrepestana-aot
deleted the
1970_fix_the_incorrect_line_number_of_detail_records
branch
andrepestana-aot
restored the
1970_fix_the_incorrect_line_number_of_detail_records
branch
andrepestana-aot
deleted the
1970_fix_the_incorrect_line_number_of_detail_records
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.