-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1970 - File integration - Fix the incorrect line number of detail records #2247
#1970 - File integration - Fix the incorrect line number of detail records #2247
Conversation
andrepestana-aot
commented
Sep 1, 2023
•
edited
Loading
edited
- Changed the code to take into account the header file line number when counting the file content line numbers.
- Fixed broken tests
Kudos, SonarCloud Quality Gate passed!
|
@@ -149,7 +149,7 @@ export class CRAIntegrationService extends SFTPIntegrationBase<CRASFTPResponseFi | |||
const statusRecords: CRAResponseStatusRecord[] = []; | |||
const totalIncomeRecords: CRAResponseTotalIncomeRecord[] = []; | |||
fileLines.forEach((line: string, index: number) => { | |||
const lineNumber = index + 1; | |||
const lineNumber = index + 2; // Take into account the removed header line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can move the comment above the line 152. same for other files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just a minor comment added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM