Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1970 - File integration - Fix the incorrect line number of detail records #2247

Merged

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Sep 1, 2023

  • Changed the code to take into account the header file line number when counting the file content line numbers.
  • Fixed broken tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.95% ( 2176 / 12121 )
Methods: 8.17% ( 126 / 1543 )
Lines: 20.82% ( 1912 / 9182 )
Branches: 9.89% ( 138 / 1396 )

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 47.47% ( 300 / 632 )
Methods: 40% ( 32 / 80 )
Lines: 51.86% ( 251 / 484 )
Branches: 25% ( 17 / 68 )

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 53.27% ( 3931 / 7379 )
Methods: 49.48% ( 472 / 954 )
Lines: 58.32% ( 3210 / 5504 )
Branches: 27.04% ( 249 / 921 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review September 1, 2023 20:52
@@ -149,7 +149,7 @@ export class CRAIntegrationService extends SFTPIntegrationBase<CRASFTPResponseFi
const statusRecords: CRAResponseStatusRecord[] = [];
const totalIncomeRecords: CRAResponseTotalIncomeRecord[] = [];
fileLines.forEach((line: string, index: number) => {
const lineNumber = index + 1;
const lineNumber = index + 2; // Take into account the removed header line.
Copy link
Contributor

@ann-aot ann-aot Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can move the comment above the line 152. same for other files

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just a minor comment added

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepestana-aot andrepestana-aot merged commit 83ee875 into main Sep 5, 2023
@andrepestana-aot andrepestana-aot deleted the 1970_fix_the_incorrect_line_number_of_detail_records branch September 5, 2023 18:02
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:11 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:12 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:12 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:12 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:12 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:15 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot temporarily deployed to DEV September 5, 2023 18:15 — with GitHub Actions Inactive
@andrepestana-aot andrepestana-aot restored the 1970_fix_the_incorrect_line_number_of_detail_records branch September 6, 2023 21:09
@andrepestana-aot andrepestana-aot deleted the 1970_fix_the_incorrect_line_number_of_detail_records branch October 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants