Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2142 - Remove date of marriage and add help text #2212

Merged
merged 1 commit into from
Aug 18, 2023
Merged

#2142 - Remove date of marriage and add help text #2212

merged 1 commit into from
Aug 18, 2023

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Aug 18, 2023 •
edited
Loading

Help Text

image

Removed date of marriage

image

@dheepak-aot dheepak-aot added the Form.io Form IO definitions changed. label Aug 18, 2023
@dheepak-aot dheepak-aot self-assigned this Aug 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.85% ( 2143 / 12004 )
Methods: 8.24% ( 126 / 1529 )
Lines: 20.67% ( 1879 / 9091 )
Branches: 9.97% ( 138 / 1384 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 53.76% ( 3876 / 7210 )
Methods: 50.38% ( 470 / 933 )
Lines: 58.75% ( 3160 / 5379 )
Branches: 27.39% ( 246 / 898 )

guru-aot
guru-aot approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ann-aot
ann-aot approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dheepak-aot

andrepestana-aot
andrepestana-aot approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dheepak-aot dheepak-aot merged commit 28f193b into main Aug 18, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:50 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:52 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:52 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:52 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:52 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:55 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV August 18, 2023 21:55 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the enhancement/#2142-remove-marriage-date branch August 25, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@dheepak-aot dheepak-aot

Labels
Form.io Form IO definitions changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dheepak-aot @guru-aot @ann-aot @andrepestana-aot