Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2111-UI format validation bulk withdrawal upload #2209
#2111-UI format validation bulk withdrawal upload #2209
Changes from 15 commits
7653b6c
6e9d841
d50375e
d63bd89
732096c
5b5d37e
12048ad
21c4eaa
836db70
8541288
177f80f
543a21e
8aba933
15828df
f68ff61
f5e5207
df2467f
2b14c20
5640b08
85f4996
3251f87
de8207c
c0cbdf7
6569267
26d7152
7fe36e5
b230d38
2dc8b4e
85c236e
9754717
b0caa5c
a921b71
0f6c531
473c319
bf400a4
3eca7cd
647edee
632971c
7901b0a
9b53153
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this method written in controller service? is there an intention to share it between controllers of different client types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my info, can we have a scenario when we process a file without doing the validations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think, even with business validations it will not do the existing validations.