#2123 - Content Fixes for Institution Account #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann-aot
added
Web Portal
Form.io
ann-aot
requested review from
dheepak-aot,
sh16011993,
guru-aot,
andrepestana-aot and
JasonCTang
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
dheepak-aot
reviewed
Aug 17, 2023
| @@ -230,7 +230,7 @@ | |||
| }, | |||
| { | |||
| "label": "Institution location code", | |||
| "tooltip": "Unique 4 digit alpha code that is assigned the first time this location is designated in Canada.", | |||
| "tooltip": "Unique 4 digit alpha code assigned the first time an institution is designated in Canada. If your institution has not yet been designated, input a random 4-letter code as a temporary Institution Location Code, and contact SABC to revise this code once your permanent code has been received. This code must be a valid federal education institution code prior to students submitting applications", | |||
dheepak-aot
approved these changes
Aug 17, 2023
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated below contents in the formio and vue file
Added a new heading to the destination agreement form and include the subheading and contents in a panel
Updated the Section B link in the destination agreement form
-Did some refactoring in the destination agreement form, as the current heading was not following the figma heading standards
Note:
Change all references to "Ministry of Advanced Education" in BC Private designation agreement to "Ministry of Post-Secondary and Future Skills.New data will always have the new name
Ministry of Post-Secondary and Future Skills. Only the old data will have the old nameMinistry of Advanced EducationTEMPfor multiple locations.I checked with @michesmith, She confirmed to go with the tooltip content for now and to create a ticket to discuss with the business and the business will possibly come up with a requirement to accommodate it. (created https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2200)
UPDATE:
Ac-1 context is updated, as per https://app.zenhub.com/workspaces/student-information-management-system-5fce9df5aa1b45000e937014/issues/gh/bcgov/sims/2200