New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1979 - Request an Offering Change - Ministry View Pending Offerings #2184

Merged

andrepestana-aot merged 29 commits into main from request_an_offering_change_ministry_view

Aug 17, 2023

Collaborator

andrepestana-aot commented Aug 11, 2023 •

edited

Loading

Created Ministry view for pending offerings;
Changed uri.ts to get the sorting direction properly;
Added an e2e test.

andrepestana-aot added 4 commits

August 10, 2023 17:54


          initial commit

8a6e7a1


          Merge branch 'main' into request_an_offering_change_ministry_view

a5d963e


          added sorting feature

a3c2884


          removed commented code

7f32a0c

andrepestana-aot changed the title ~~initial commit~~ #1979 - Request an Offering Change - Ministry View Pending Offerings

andrepestana-aot added 6 commits

August 14, 2023 10:34


          sonar issues

e15893a


          pushing to test

0ac8f8b


          fixed provider issue and e2e test

66c7e0e


          fixed e2e test

fe75d7e


          fixed sorting; added test

9fb157e


          removed unused import

df44ed8

andrepestana-aot marked this pull request as ready for review

August 15, 2023 20:11

andrepestana-aot requested review from ann-aot, guru-aot, sh16011993 and dheepak-aot

August 15, 2023 20:11

andrepestana-aot self-assigned this


          fixed comment

06e4890

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...ication-offering-change-request.institutions.controller.getCompletedApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...cation-offering-change-request.institutions.controller.getInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...ation-offering-change-request/application-offering-change-request.institutions.controller.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...ation-offering-change-request/models/application-offering-change-request.institutions.dto.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...ation-offering-change-request/models/application-offering-change-request.institutions.dto.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

sources/packages/backend/libs/sims-db/src/pagination-utils.ts Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

sources/packages/web/src/helpers/helpers/uri.ts Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

sources/packages/web/src/services/http/ApplicationOfferingChangeRequestApi.ts Outdated Show resolved Hide resolved

sh16011993 approved these changes

View reviewed changes

Collaborator

sh16011993 left a comment

LGTM @andrepestana-aot 👍

dheepak-aot reviewed

View reviewed changes

.../services/application-offering-change-request/application-offering-change-request.service.ts Show resolved Hide resolved

dheepak-aot reviewed

View reviewed changes

...s/application-offering-change-request/application-offering-change-request.aest.controller.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...s/application-offering-change-request/models/application-offering-change-request.aest.dto.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

Contributor

ann-aot left a comment

Added some comments

andrepestana-aot added 4 commits

August 16, 2023 14:47


          PR issues

abf0d15


          PR issues

dde75b2


          PR issues

8607bcd


          PR issues

431235b

dheepak-aot approved these changes

View reviewed changes

Collaborator

dheepak-aot left a comment

Thanks for making the changes. 👍

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

ann-aot reviewed

View reviewed changes

...application-offering-change-request.aest.controller.getAllInProgressApplications.e2e-spec.ts Outdated Show resolved Hide resolved

andrepestana-aot added 3 commits

August 17, 2023 13:07


          PR issues

7e7b9b9


          PR issues

102e764


          PR issues

c18a312

sonarqubecloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions bot commented Aug 17, 2023

Backend Unit Tests Coverage Report

Totals
Statements:	17.85% ( 2143 / 12004 )
Methods:	8.24% ( 126 / 1529 )
Lines:	20.67% ( 1879 / 9091 )
Branches:	9.97% ( 138 / 1384 )

github-actions bot commented Aug 17, 2023

E2E Queue Consumers Coverage Report

Totals
Statements:	72.5% ( 406 / 560 )
Methods:	63.38% ( 45 / 71 )
Lines:	74.53% ( 357 / 479 )
Branches:	40% ( 4 / 10 )

github-actions bot commented Aug 17, 2023

E2E Workflow Workers Coverage Report

Totals
Statements:	49.81% ( 267 / 536 )
Methods:	41.56% ( 32 / 77 )
Lines:	55.33% ( 218 / 394 )
Branches:	26.15% ( 17 / 65 )

github-actions bot commented Aug 17, 2023

E2E SIMS API Coverage Report

Totals
Statements:	53.76% ( 3876 / 7210 )
Methods:	50.38% ( 470 / 933 )
Lines:	58.75% ( 3160 / 5379 )
Branches:	27.39% ( 246 / 898 )

ann-aot approved these changes

View reviewed changes

Contributor

ann-aot left a comment

Thanks @andrepestana-aot for the changes 👍 Looks good to me

andrepestana-aot merged commit 017c79f into main

andrepestana-aot deleted the request_an_offering_change_ministry_view branch

August 17, 2023 20:50

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:05

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:07

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:07

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:07

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:07

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:09

— with

GitHub Actions Inactive

andrepestana-aot temporarily deployed to DEV

August 17, 2023 21:09

— with

GitHub Actions Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet