Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2150 - TESTING BUG - Unable to search student in the Support user portal (Parent/partner declaration portal) #2159

Merged
merged 2 commits into from
Aug 3, 2023
Merged

#2150 - TESTING BUG - Unable to search student in the Support user portal (Parent/partner declaration portal) #2159

merged 2 commits into from
Aug 3, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Aug 2, 2023 •
edited
Loading

  • Partner and partner When searching for the student application, I couldn't find any issue in my local, As discussed in the call, look like the loading issue mentioned in the ticket was due to point 4.
  • Supporting partner data submission was failing - fixed
  • Did an overall smoke test in the supporting user portal - everything looks fine.
  • Supporting user form was not correct in TEST db, updated it
    image
  • Fixed a small UI issue - Once you search for an existing application and then try to search for a nonexisting application the form's Next step and back btn was still visible
    Issue
    image
    Fix
    image

Screenshots
image
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.87% ( 2137 / 11957 )
Methods: 8.26% ( 126 / 1525 )
Lines: 20.68% ( 1873 / 9059 )
Branches: 10.05% ( 138 / 1373 )

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 52.65% ( 3757 / 7136 )
Methods: 49.3% ( 457 / 927 )
Lines: 57.73% ( 3074 / 5325 )
Branches: 25.57% ( 226 / 884 )

@ann-aot ann-aot marked this pull request as ready for review August 3, 2023 19:56
@ann-aot ann-aot self-assigned this Aug 3, 2023
dheepak-aot
dheepak-aot approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍Thanks for doing additional refactors.

andrewsignori-aot
andrewsignori-aot approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for the navigation fix and reactors. Looks good 👍

@andrewsignori-aot andrewsignori-aot changed the title #2150- TESTING BUG - Unable to search student in the Support user portal (Parent/partner declaration portal) #2150 - TESTING BUG - Unable to search student in the Support user portal (Parent/partner declaration portal) Aug 3, 2023
sh16011993
sh16011993 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

guru-aot
guru-aot approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ann-aot

@ann-aot ann-aot merged commit 4ca7902 into main Aug 3, 2023
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:03 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:04 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:04 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:04 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:04 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:07 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV August 3, 2023 22:07 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-#2150 branch August 3, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

Assignees

@ann-aot ann-aot

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ann-aot @sh16011993 @dheepak-aot @andrewsignori-aot @guru-aot