#2134 - Increase the max length of operating and legal operating name to 250 #2140
Conversation
dheepak-aot
requested review from
andrewsignori-aot,
sh16011993,
guru-aot,
ann-aot and
JasonCTang
dheepak-aot
added
DB
| @@ -395,7 +396,7 @@ | |||
| "validate": { | |||
| "required": true, | |||
| "minLength": "", | |||
| "maxLength": 100, | |||
| "maxLength": 250, | |||
There was a problem hiding this comment.
Nice catch updating this form also.
Can we have an AC added to the ticket to make it clear that the update process by the Ministry is also a scenario to be tested by the business?
@JasonCTang FYI
| @@ -346,7 +346,8 @@ | |||
| "addons": [], | |||
| "inputType": "text", | |||
| "id": "eiloy9e", | |||
| "defaultValue": "" | |||
| "defaultValue": "", | |||
| "isNew": false | |||
There was a problem hiding this comment.
just wondering, are we not adding the max length to legalOperatingName. same for the other form
There was a problem hiding this comment.
We consider that @ann-aot but the legalOperatingName is displayed here for info only. The value is retrieved from the token directly, not from the UI, so there is no real point in adding a validation here since we have the confirmation about the 250 characters.
There was a problem hiding this comment.
Yes, the value is read from the response of bceid web service.
There was a problem hiding this comment.
@andrewsignori-aot , I just thought twice, we are re-using the same form(institution profile) to create institution by ministry right. should we use the validation then?
There was a problem hiding this comment.
mm, ya... but I was wondering, what if they increased the length (and we have 250), and now there is a new institution with more than 250 characters of legal name, then the same error which we saw today will happen again right? but if we add the max length here, at least the user will not be able to submit due to validation and the user will at least know the issue right?
but, I am good with what we have in the PR, just sharing my thoughts
There was a problem hiding this comment.
Yes, that makes sense @dheepak-aot, nice catch.
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
|
Kudos, SonarCloud Quality Gate passed!
|
dheepak-aot
deleted the
fix/#2134-update-operating-and-legal-operating-name-length
branch
Increase the max length in formio and db for operating name and legal operating name
Institution Creation exceeding 250 characters
Institution Creation within 250 characters