#2044 Add Ignore errors and timeout for ORM Cache #2130
Merged
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
requested review from
andrewsignori-aot,
guru-aot,
ann-aot,
sh16011993 and
JasonCTang
andrewsignori-aot
approved these changes
Jul 26, 2023
guru-aot
reviewed
Jul 26, 2023
| * Ref for cluster: https://github.com/redis/ioredis/tree/v4#cluster | ||
| */ | ||
| export const ORM_CACHE_REDIS_RETRY_INTERVAL = 60 * 1000; | ||
|
|
There was a problem hiding this comment.
For my understanding. Why are we having the redis retry and the timeout same interval? Doesnt the retry should be lesser or the timeout more?
guru-aot
reviewed
Jul 26, 2023
| }, | ||
| ignoreErrors: true, |
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
|
Kudos, SonarCloud Quality Gate passed!
|
guru-aot
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore Errors and add timeout
ignoreErrors: trueto the orm cache config.commandTimeoutof redis to 60 seconds in cache config which is infinite by default.Retry Strategy (https://github.com/redis/ioredis/tree/v4#auto-reconnect)
When
ignoreErrors: trueis set, errors are ignored and the typeorm works normally but the redis client(ioredis and ioredis/cluster) does retry every 2 seconds to connect again to redis server and creates log for every retry.This is due to the default implementation of
retryStrategyandclusterRetryStrategy.