#2001 - Updating the cache name of redhat docker image artifactory #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
requested review from
sh16011993,
andrewsignori-aot,
guru-aot,
ann-aot and
JasonCTang
dheepak-aot
changed the title
guru-aot
reviewed
Jul 24, 2023
| @oc -n $(BUILD_NAMESPACE) start-build bc/$(API_BUILD_REF) --wait | ||
|
|
||
| build-workers: | ||
| test -n "$(BUILD_NAMESPACE)" | ||
| test -n "$(BUILD_REF)" | ||
| test -n "$(WORKERS_BUILD_REF)" | ||
| @echo "+\n++ BUILDING WORKERS with tag: $(BUILD_REF)\n+" | ||
| @oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/workers/Dockerfile -p NAME=$(WORKERS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f - | ||
| @oc -n $(BUILD_NAMESPACE) process -f $(BUILD_TEMPLATE_PATH) -p TAG=$(BUILD_REF) -p SOURCE_REPOSITORY_REF=$(BUILD_REF) -p BASE_IMAGE_NAME="nodejs-16" -p BASE_IMAGE_TAG="1" -p BASE_IMAGE_REPO="artifacts.developer.gov.bc.ca/redhat-access-docker-remote/ubi8/" -p SOURCE_CONTEXT_DIR=$(SOURCE_CONTEXT_DIR)backend -p DOCKER_FILE_PATH=apps/workers/Dockerfile -p NAME=$(WORKERS_BUILD_REF) | oc -n $(BUILD_NAMESPACE) apply -f - |
There was a problem hiding this comment.
@dheepak-aot i know its not part of your change, just curious did we check we have node js 18 version available??
There was a problem hiding this comment.
redhat-access-docker-remote is just a cache of registry.access.redhat.com. So Yes, node-18 is available there.
guru-aot
approved these changes
Jul 24, 2023
andrewsignori-aot
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the artifactory cache
As per rocketchat, the docket image atifactory cache
redhat-docker-remoteis pointing toregistry.connect.redhat.comand not theregistry.access.redhat.com.Hence updated the cache to
redhat-access-docker-remote