Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1874-Sysdig Monitoring Team creation #2128

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

guru-aot
Copy link
Collaborator

Sysdig monitoring team creation yml is created to run the agent in our namespace in openshift.

@guru-aot guru-aot self-assigned this Jul 24, 2023
@guru-aot guru-aot added the Devops Devops label Jul 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.87% ( 2134 / 11940 )
Methods: 8.29% ( 126 / 1520 )
Lines: 20.67% ( 1870 / 9047 )
Branches: 10.05% ( 138 / 1373 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 52.23% ( 3716 / 7115 )
Methods: 48.59% ( 448 / 922 )
Lines: 57.36% ( 3045 / 5309 )
Branches: 25.23% ( 223 / 884 )

role: ROLE_TEAM_EDIT
- name: [email protected]
role: ROLE_TEAM_EDIT
- name: [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we use our gov email here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The login in controlled via github single sign on, the sysdig application verifies the email id configured in your github id. As we are using our github id created from aot, we have to use our ato technologies email.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my clarification. We're not sending alerts to everyone on this list right? ALl these people should have access, but not receive email alerts directly. We will want to send the alerts to a generic email address.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the alerts, there are none right now, we can create a Email notification channel where all the emails can go to a generic email address.

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work with sysdig 👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@JasonCTang JasonCTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed permissions and they are correct.

@guru-aot guru-aot merged commit ec39952 into main Jul 25, 2023
@guru-aot guru-aot deleted the #1874-Sysdig-Monitoring branch July 25, 2023 23:23
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:32 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:33 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:33 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:33 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:33 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:35 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV July 25, 2023 23:35 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants