Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2126 - Add missing property on student account creation #2127

Merged
merged 1 commit into from
Jul 21, 2023
Merged

#2126 - Add missing property on student account creation #2127

merged 1 commit into from
Jul 21, 2023

Conversation

dheepak-aot
Copy link
Collaborator

Added missing property identityProvider

@dheepak-aot dheepak-aot self-assigned this Jul 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.87% ( 2134 / 11940 )
Methods: 8.29% ( 126 / 1520 )
Lines: 20.67% ( 1870 / 9047 )
Branches: 10.05% ( 138 / 1373 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 72.5% ( 406 / 560 )
Methods: 63.38% ( 45 / 71 )
Lines: 74.53% ( 357 / 479 )
Branches: 40% ( 4 / 10 )

ann-aot
ann-aot approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 52.23% ( 3716 / 7115 )
Methods: 48.59% ( 448 / 922 )
Lines: 57.36% ( 3045 / 5309 )
Branches: 25.23% ( 223 / 884 )

guru-aot
guru-aot approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot merged commit bd3fb0c into main Jul 21, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:06 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:07 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:07 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:07 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:07 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:09 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 21, 2023 23:09 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the bug/#2126-create-student-not-working branch August 1, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@dheepak-aot dheepak-aot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dheepak-aot @guru-aot @ann-aot