Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1977 - Request Offering Change: Student Application Tracker - Part 1 [Email Notification] #2114

Conversation

sh16011993
Copy link
Collaborator

As a part of this PR, added an email notification template to GC Notify for the scenario: offering change request In progress with student and added the code to save a notification message when the application offering change request is created successfully by the institution.

Screenshot attached below:

image

@sh16011993 sh16011993 self-assigned this Jul 14, 2023
@sh16011993 sh16011993 added SIMS-Api SIMS-Api DB DB migration involved labels Jul 14, 2023
VALUES
(
13,
'Offering Change Request Inprogress With Student',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have the notification details also in the ticket.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification details for offering change request In progress with student are present in the ticket. Not sure if Jason wants to change it to have a common template for all 3 scenarios - in progress with student, approved and declined by SABC.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have the notification details also in the ticket.

By details I meant that the 'Offering Change Request Inprogress With Student' would be part of the ticket AC also.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check it with @JasonCTang

VALUES
(
13,
'Offering Change Request Inprogress With Student',
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the "Inprogress". Please ensure that the spell checker is also enabled for SQL files.
Was this message reviewed by the business? The idea is that these messages can potentially be shown to the user someday.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed with the business yet. I will check it with @JasonCTang

@@ -136,4 +136,8 @@ export enum NotificationMessageType {
* MSFAA record gets cancelled.
*/
MSFAACancellation = 12,
/**
* OfferingChangeRequest is in progress with student.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is called "Application offering change request" in an attempt to differentiate from the other "offering request" that can be requested by the institution.
Can we have at least the comment changed to "An Application Offering Change Request is in progress with the student."?

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Please take a look at the comments.

VALUES
(
13,
'Offering Change Request Inprogress With Student',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also include application, so it is `Application Offering Change Request In progress With Student',

@@ -30,6 +30,13 @@ export interface MSFAACancellationNotification {
userId: number;
}

export interface OfferingChangeRequestInProgressWithStudentNotification {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding application to the name will help differentiate it from the actual offering change

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments

VALUES
(
13,
'Application Offering Change Request In Progress With Student',
Copy link
Collaborator

@dheepak-aot dheepak-aot Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say the message type could be "Institution requests a change"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested the message from @JasonCTang as well since it might be shown to the users someday.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with business area that the wording is good to go!

* @param auditUserId user that should be considered the one that is causing the changes.
* @param entityManager optional entity manager to execute in transaction.
*/
async saveOfferingChangeRequestInProgressWithStudent(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saveInstitutionRequestChangeNotification ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a common template for all 3 scenarios, I will update the names everywhere.

/**
* An Application Offering Change Request is in progress with the student.
*/
OfferingChangeRequestInProgressWithStudent = 13,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a common template for all 3 scenarios, I will update the names everywhere.

@dheepak-aot
Copy link
Collaborator

Good Job. Added some minor comments.

@JasonCTang
Copy link
Collaborator

Discussed with Shashank and we will be sticking to this template for the initial email to the student when the institution first submits the request to change an offering for said student.

A separate single template will be used to notify the student regarding the actions that the Ministry takes on the request later in the process.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.83% ( 2130 / 11943 )
Methods: 8.29% ( 126 / 1520 )
Lines: 20.62% ( 1866 / 9050 )
Branches: 10.05% ( 138 / 1373 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 49.89% ( 3553 / 7122 )
Methods: 45.18% ( 417 / 923 )
Lines: 55.08% ( 2926 / 5312 )
Branches: 23.68% ( 210 / 887 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sh16011993

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for doing the changes @sh16011993 👍

@sh16011993 sh16011993 merged commit 4390d05 into main Jul 19, 2023
@sh16011993 sh16011993 deleted the 1977_request_offering_change_student_application_tracker_part_1_email_notification branch July 19, 2023 23:22
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:36 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:37 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:37 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:37 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:37 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:39 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 19, 2023 23:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB DB migration involved SIMS-Api SIMS-Api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants