#1977 - Request Offering Change: Student Application Tracker - Part 1 [Email Notification] #2114
Conversation
…1 [Email Notification]
sh16011993
requested review from
andrewsignori-aot,
dheepak-aot,
ann-aot,
guru-aot,
hellolynn-tbtb and
JasonCTang
and removed request for
hellolynn-tbtb
.../services/application-offering-change-request/application-offering-change-request.service.ts
Outdated
Show resolved
Hide resolved
| VALUES | ||
| ( | ||
| 13, | ||
| 'Offering Change Request Inprogress With Student', |
There was a problem hiding this comment.
It would be good to have the notification details also in the ticket.
There was a problem hiding this comment.
Notification details for offering change request In progress with student are present in the ticket. Not sure if Jason wants to change it to have a common template for all 3 scenarios - in progress with student, approved and declined by SABC.
There was a problem hiding this comment.
It would be good to have the notification details also in the ticket.
By details I meant that the 'Offering Change Request Inprogress With Student' would be part of the ticket AC also.
There was a problem hiding this comment.
I will check it with @JasonCTang
| VALUES | ||
| ( | ||
| 13, | ||
| 'Offering Change Request Inprogress With Student', |
There was a problem hiding this comment.
Please fix the "Inprogress". Please ensure that the spell checker is also enabled for SQL files.
Was this message reviewed by the business? The idea is that these messages can potentially be shown to the user someday.
There was a problem hiding this comment.
I haven't reviewed with the business yet. I will check it with @JasonCTang
| @@ -136,4 +136,8 @@ export enum NotificationMessageType { | |||
| * MSFAA record gets cancelled. | |||
| */ | |||
| MSFAACancellation = 12, | |||
| /** | |||
| * OfferingChangeRequest is in progress with student. | |||
There was a problem hiding this comment.
The feature is called "Application offering change request" in an attempt to differentiate from the other "offering request" that can be requested by the institution.
Can we have at least the comment changed to "An Application Offering Change Request is in progress with the student."?
| VALUES | ||
| ( | ||
| 13, | ||
| 'Offering Change Request Inprogress With Student', |
There was a problem hiding this comment.
shouldn't we also include application, so it is `Application Offering Change Request In progress With Student',
| @@ -30,6 +30,13 @@ export interface MSFAACancellationNotification { | |||
| userId: number; | |||
| } | |||
|
|
|||
| export interface OfferingChangeRequestInProgressWithStudentNotification { | |||
There was a problem hiding this comment.
Maybe adding application to the name will help differentiate it from the actual offering change
| VALUES | ||
| ( | ||
| 13, | ||
| 'Application Offering Change Request In Progress With Student', |
There was a problem hiding this comment.
I would say the message type could be "Institution requests a change"
There was a problem hiding this comment.
I have requested the message from @JasonCTang as well since it might be shown to the users someday.
There was a problem hiding this comment.
Confirmed with business area that the wording is good to go!
| * @param auditUserId user that should be considered the one that is causing the changes. | ||
| * @param entityManager optional entity manager to execute in transaction. | ||
| */ | ||
| async saveOfferingChangeRequestInProgressWithStudent( |
There was a problem hiding this comment.
saveInstitutionRequestChangeNotification ?
There was a problem hiding this comment.
If there is a common template for all 3 scenarios, I will update the names everywhere.
| /** | ||
| * An Application Offering Change Request is in progress with the student. | ||
| */ | ||
| OfferingChangeRequestInProgressWithStudent = 13, |
There was a problem hiding this comment.
There was a problem hiding this comment.
If there is a common template for all 3 scenarios, I will update the names everywhere.
|
Good Job. Added some minor comments. |
|
Discussed with Shashank and we will be sticking to this template for the initial email to the student when the institution first submits the request to change an offering for said student. A separate single template will be used to notify the student regarding the actions that the Ministry takes on the request later in the process. |
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
deleted the
1977_request_offering_change_student_application_tracker_part_1_email_notification
branch
As a part of this PR, added an email notification template to GC Notify for the scenario: offering change request In progress with student and added the code to save a notification message when the application offering change request is created successfully by the institution.
Screenshot attached below: