Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2047 - Change BC Sans font with version 2 #2103

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Jul 11, 2023

As a part of this PR, upgraded the BC Sans from version 1 to version 2. This upgrade allows for the support of indigenous languages.

The following symbols are tested:

image

Screenshots related to testing:

Vuetify testing (Veutify --> database --> webpage) :

Database -
image

Webpage -
image

Formio testing (Formio --> database --> webpage) :

Formio -
image

Database -
image

Webpage -
image

Verified

This commit was signed with the committer’s verified signature. The key has expired.
chfast Paweł Bylica
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to know why 5 files are and only 3 files are added. What about other files?

@ann-aot
Copy link
Contributor

ann-aot commented Jul 11, 2023

I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files?

@ann-aot
Copy link
Contributor

ann-aot commented Jul 11, 2023

Just wanted to know why 5 files are and only 3 files are added. What about other files?

we have 8 files, right?
image

@sh16011993
Copy link
Collaborator Author

I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files?

@andrewsignori-aot shared the BC Sans github project link.

@sh16011993
Copy link
Collaborator Author

sh16011993 commented Jul 11, 2023

Just wanted to know why 5 files are and only 3 files are added. What about other files?

we have 8 files, right? image

All the 8 files are present.

@sh16011993
Copy link
Collaborator Author

Just wanted to know why 5 files are and only 3 files are added. What about other files?

There are 8 files.

@ann-aot
Copy link
Contributor

ann-aot commented Jul 11, 2023

I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files?

@andrewsignori-aot shared the BC Sans github project link.

Thanks for sharing the link, a question for the dev @andrewsignori-aot , @dheepak-aot , @guru-aot, and @hellolynn-tbtb , I see there are 12 files https://github.com/bcgov/bc-sans/tree/master/fonts, but we have only 8 files in our project. shouldn't we add all 12 files?

@dheepak-aot
Copy link
Collaborator

dheepak-aot commented Jul 12, 2023

I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files?

@andrewsignori-aot shared the BC Sans github project link.

Thanks for sharing the link, a question for the dev @andrewsignori-aot , @dheepak-aot , @guru-aot, and @hellolynn-tbtb , I see there are 12 files https://github.com/bcgov/bc-sans/tree/master/fonts, but we have only 8 files in our project. shouldn't we add all 12 files?

Hello team, when I clicked at this link, I was able to download all the version2 of BC Sans Font.
image

It has both woff and woff2 font files

image

I believe the github link must be considered as source to download fonts. But not sure.

@ann-aot Thanks for bringing the point. IMO yes we must add the remaining fonts as well.

@sh16011993
Copy link
Collaborator Author

I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files?

@andrewsignori-aot shared the BC Sans github project link.

Thanks for sharing the link, a question for the dev @andrewsignori-aot , @dheepak-aot , @guru-aot, and @hellolynn-tbtb , I see there are 12 files https://github.com/bcgov/bc-sans/tree/master/fonts, but we have only 8 files in our project. shouldn't we add all 12 files?

Hello team, when I clicked at this link, I was able to download all the version2 of BC Sans Font. image

It has both woff and woff2 font files

image

I believe the github link must be considered as source to download fonts. But not sure.

@ann-aot Thanks for bringing the point. IMO yes we must add the remaining fonts as well.

I had called the BC Service help when I wasn't able to download the files and they must have fixed it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update our BCSans.scss as below and just ensure that we have those files associated?
https://developer.gov.bc.ca/Typography#font-face

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that should be enought too.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the npm package, looks good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sh16011993

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes 👍 LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2129 / 11899 )
Methods: 8.31% ( 126 / 1516 )
Lines: 20.69% ( 1865 / 9016 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3545 / 7064 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2917 / 5267 )
Branches: 23.84% ( 210 / 881 )

@sh16011993 sh16011993 merged commit cdfd62a into main Jul 12, 2023
@sh16011993 sh16011993 deleted the 2047_change_bc_sans_font_v2 branch July 12, 2023 23:32
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:46 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:47 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:47 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:47 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:47 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:49 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV July 12, 2023 23:49 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants