-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2047 - Change BC Sans font with version 2 #2103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to know why 5 files are and only 3 files are added. What about other files?
I remember the link shared by @hellolynn-tbtb to download the new files was not working, would like to know, from where did u get these new files? |
@andrewsignori-aot shared the BC Sans github project link. |
There are 8 files. |
Thanks for sharing the link, a question for the dev @andrewsignori-aot , @dheepak-aot , @guru-aot, and @hellolynn-tbtb , I see there are 12 files https://github.com/bcgov/bc-sans/tree/master/fonts, but we have only 8 files in our project. shouldn't we add all 12 files? |
Hello team, when I clicked at this link, I was able to download all the version2 of BC Sans Font. It has both woff and woff2 font files I believe the github link must be considered as source to download fonts. But not sure. @ann-aot Thanks for bringing the point. IMO yes we must add the remaining fonts as well. |
I had called the BC Service help when I wasn't able to download the files and they must have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update our BCSans.scss
as below and just ensure that we have those files associated?
https://developer.gov.bc.ca/Typography#font-face
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that should be enought too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into the npm package, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @sh16011993
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes 👍 LGTM
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
As a part of this PR, upgraded the BC Sans from version 1 to version 2. This upgrade allows for the support of indigenous languages.
The following symbols are tested:
Screenshots related to testing:
Vuetify testing (Veutify --> database --> webpage) :
Database -

Webpage -

Formio testing (Formio --> database --> webpage) :
Formio -

Database -

Webpage -
