Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2034 - Update student form to validate new separate minimum offering days for Fulltime vs Parttime. #2091

Merged
merged 2 commits into from
Jul 10, 2023
Merged

#2034 - Update student form to validate new separate minimum offering days for Fulltime vs Parttime. #2091

merged 2 commits into from
Jul 10, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Jul 7, 2023 •
edited
Loading

  • Added separate student period minimum logic for all the 3 days. used the same logic as that of offering form.
  • The entire file is showing the change in "sfaa2022-23.json" as it was CRLF and it has been changed to LF.

Screenshots
Full time
image
Part time
image

@ann-aot ann-aot self-assigned this Jul 7, 2023
@ann-aot ann-aot added the Form.io Form IO definitions changed. label Jul 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11892 )
Methods: 8.31% ( 126 / 1516 )
Lines: 20.68% ( 1863 / 9009 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

andrewsignori-aot
andrewsignori-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

guru-aot
guru-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ann-aot

dheepak-aot
dheepak-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work 👍

sh16011993
sh16011993 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ann-aot ann-aot merged commit c62860b into main Jul 10, 2023
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:48 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:52 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:52 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:52 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:52 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 10, 2023 17:58 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the task/sims-#2034 branch July 11, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
Form.io Form IO definitions changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ann-aot @sh16011993 @dheepak-aot @andrewsignori-aot @guru-aot