#2022 - Form.io definitions cache update for releases #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann-aot
requested review from
andrewsignori-aot,
sh16011993,
dheepak-aot,
guru-aot and
JasonCTang
ann-aot
changed the title
andrewsignori-aot
approved these changes
Jul 6, 2023
dheepak-aot
reviewed
Jul 6, 2023
| * Gets the current API version. | ||
| * @returns current API version. | ||
| */ | ||
| get getAPIVersion(): string { |
There was a problem hiding this comment.
It is already a getter. So the name could be just apiVersion. get apiVersion()
dheepak-aot
approved these changes
Jul 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM @ann-aot 👍 . Nice work. Thank You for the doubt clarification via code walkthrough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenshots