Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2022 - Form.io definitions cache update for releases #2084

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Jul 5, 2023

  • version added to form name
    screenshots
    image

@ann-aot ann-aot self-assigned this Jul 5, 2023
@ann-aot ann-aot added Web Portal Form.io Form IO definitions changed. labels Jul 5, 2023
@ann-aot ann-aot changed the title #2022 - version added to form name #2022 - Form.io definitions cache update for releases Jul 6, 2023
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good 👍

* Gets the current API version.
* @returns current API version.
*/
get getAPIVersion(): string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already a getter. So the name could be just apiVersion. get apiVersion()

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ann-aot . One minor comment.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11892 )
Methods: 8.31% ( 126 / 1516 )
Lines: 20.68% ( 1863 / 9009 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ann-aot 👍 . Nice work. Thank You for the doubt clarification via code walkthrough.

@ann-aot ann-aot merged commit 56ee1a0 into main Jul 6, 2023
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 20:56 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 20:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 20:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 20:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 20:58 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 21:01 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 6, 2023 21:01 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the task/sims-#2022 branch July 6, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants