Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1957 - Ministry - Build out the ministry homepage #2079

Merged
merged 1 commit into from
Jul 5, 2023
Merged

#1957 - Ministry - Build out the ministry homepage #2079

merged 1 commit into from
Jul 5, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Jul 4, 2023 •
edited
Loading

  • Updated ministry dashboard
  • screenshots
    image
    image
    image
    image
    image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11890 )
Methods: 8.32% ( 126 / 1515 )
Lines: 20.68% ( 1863 / 9008 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

@ann-aot ann-aot self-assigned this Jul 4, 2023
@ann-aot ann-aot added Web Portal Form.io Form IO definitions changed. labels Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

@ann-aot ann-aot marked this pull request as ready for review July 4, 2023 23:36
andrewsignori-aot
andrewsignori-aot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks great. Looks good to me 👍

guru-aot
guru-aot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ann-aot

dheepak-aot
dheepak-aot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

sh16011993
sh16011993 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Nice work @ann-aot

hellolynn-tbtb
hellolynn-tbtb approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@hellolynn-tbtb hellolynn-tbtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ann-aot ! Looks great

@ann-aot ann-aot merged commit 25b5203 into main Jul 5, 2023
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:02 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:09 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV July 5, 2023 18:09 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the task/sims-#1957 branch July 5, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@hellolynn-tbtb hellolynn-tbtb hellolynn-tbtb approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@ann-aot ann-aot

Labels
Form.io Form IO definitions changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ann-aot @sh16011993 @dheepak-aot @hellolynn-tbtb @andrewsignori-aot @guru-aot