#2059 - Rename Item in Regulatory Dropdown Field for Institutions #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
requested review from
dheepak-aot,
hellolynn-tbtb,
andrewsignori-aot,
ann-aot,
JasonCTang and
guru-aot
ann-aot
reviewed
Jul 5, 2023
| await queryRunner.query( | ||
| getSQLFileData( | ||
| "Update-regulatory-body-ita-code.sql", | ||
| "EducationPrograms", |
There was a problem hiding this comment.
just wondering, since the migration affects 2 different entities. how about creating 2 .sql files in the respective entity folders, and add in the same migration file? something like this,
There was a problem hiding this comment.
For history, I think that it would be better as @ann-aot mentioned.
The idea to have the SQL files more table centered is to check the changes along the time with a particular entity, so it would make sense.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
guru-aot
reviewed
Jul 5, 2023
E2E SIMS API Coverage Report
|
ann-aot
approved these changes
Jul 5, 2023
andrewsignori-aot
approved these changes
Jul 5, 2023
sh16011993
deleted the
2059_institutions_rename_item_in_regulatory_dropdown_field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, updated the ITA to Skilled Trades BC label in the Regulatory Program Dropdown of the Create Program Institution page.
Screenshot of the dropdown menu for Create Program page:
Screenshot of the dropdown menu for Institution Create Profile page:
There is also database migration to change the existing ita values in the database to skilledTradesBC value for both the institutions and education programs relations.