Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1658 - Address fields display for institutions and ministry users #2070

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Jun 30, 2023

  • Institution locations address formatted as below. The same component is shared between Mnistry and Institutions so the change affects both places.
  • Removed column for address line 2.
  • Added orderBy to the query returning locations because every time that one item was edited they kept switching orders.

image

@andrewsignori-aot andrewsignori-aot added Bug Something isn't working Institution Institution Features labels Jun 30, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this Jun 30, 2023
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review June 30, 2023 21:03
* address component represents an entry in the array.
* @param address address to be formatted.
* @returns string array with ordered address components.
* @example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

// Address line 2
formattedAddress.push(address.addressLine2);
}
// Country, province, postal code.
Copy link
Collaborator

@andrepestana-aot andrepestana-aot Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// City, ... ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted.

// Country, province, postal code.
const cityPostalCountry: string[] = [];
cityPostalCountry.push(address.city);
if (address.provinceState) {
Copy link
Collaborator

@andrepestana-aot andrepestana-aot Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my info: I see that provinceState is optional in Address. Shouldn't it be mandatory?

Copy link
Collaborator Author

@andrewsignori-aot andrewsignori-aot Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not mandatory because the addressees outside Canada when we do not capture this information.

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just minor comments.

:key="addressLine"
data-cy="institutionAddress1"
>
{{ addressLine }}
</span>
</v-col>

<!-- Address 2 -->
<v-col>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my info, so, there won't be address 2 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as a separate column. It was supposed to be the "Address Line 2" (if I am not wrong).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm, actually I think, the old plan was that there can be 2 addresses for the institution (although we don't have anything in place to capture the 2nd address now), Address 1 and Address 2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe that also. There was a plan for a sort of home address/mailing address but it was dropped a long time ago.
Either way, seems to be pretty simple now.

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. just a small question

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11890 )
Methods: 8.32% ( 126 / 1515 )
Lines: 20.68% ( 1863 / 9008 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsignori-aot andrewsignori-aot merged commit d432024 into main Jun 30, 2023
@andrewsignori-aot andrewsignori-aot deleted the fix/#1658-institution-address-fields branch June 30, 2023 22:30
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:40 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:41 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:41 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:41 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:41 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:43 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 30, 2023 22:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Institution Institution Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants