Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1953 - Request an Offering Change - Fix #2065

Merged
merged 1 commit into from
Jun 29, 2023
Merged

#1953 - Request an Offering Change - Fix #2065

merged 1 commit into from
Jun 29, 2023

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Jun 29, 2023

  • In the completed search test case, there are multiple search results with the default order of application number. Did a fix to set the application number in order to predict the order while asserting.

@ann-aot ann-aot self-assigned this Jun 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

andrewsignori-aot
andrewsignori-aot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrepestana-aot
andrepestana-aot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.91% ( 2126 / 11870 )
Methods: 8.33% ( 126 / 1513 )
Lines: 20.7% ( 1862 / 8994 )
Branches: 10.12% ( 138 / 1363 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

sh16011993
sh16011993 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.16% ( 3539 / 7056 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.35% ( 2912 / 5261 )
Branches: 23.78% ( 209 / 879 )

@ann-aot ann-aot merged commit 51b67b8 into main Jun 29, 2023
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:31 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:32 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:32 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:32 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:32 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:35 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 30, 2023 00:35 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the feature/sims-1953/fix branch June 30, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@dheepak-aot dheepak-aot Awaiting requested review from dheepak-aot

@guru-aot guru-aot Awaiting requested review from guru-aot

Assignees

@ann-aot ann-aot

Labels
E2E/Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ann-aot @sh16011993 @andrewsignori-aot @andrepestana-aot