Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2058 - Add new program regulatory option #2064

Merged
merged 1 commit into from
Jun 29, 2023
Merged

#2058 - Add new program regulatory option #2064

merged 1 commit into from
Jun 29, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Jun 29, 2023 •
edited
Loading

  • Added new entry to the program's regulatory options.
    • Label: Senate, Academic Council, Education Council, and/or Program Council and Board of Governors
    • Value: senateOrEducationCouncil

image

@andrewsignori-aot andrewsignori-aot added the Institution Institution Features label Jun 29, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this Jun 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review June 29, 2023 18:19
@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.91% ( 2086 / 11648 )
Methods: 8.27% ( 123 / 1488 )
Lines: 20.68% ( 1827 / 8835 )
Branches: 10.26% ( 136 / 1325 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

sh16011993
sh16011993 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.54% ( 3032 / 6964 )
Methods: 37.75% ( 339 / 898 )
Lines: 48.6% ( 2526 / 5197 )
Branches: 19.22% ( 167 / 869 )

dheepak-aot
dheepak-aot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ann-aot
ann-aot approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsignori-aot andrewsignori-aot merged commit 0efafb2 into hotfix/v1.0.1 Jun 29, 2023
@andrewsignori-aot andrewsignori-aot deleted the fix/#2058-add-new-regulatory-body branch June 29, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@hellolynn-tbtb hellolynn-tbtb Awaiting requested review from hellolynn-tbtb

@andrepestana-aot andrepestana-aot Awaiting requested review from andrepestana-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Institution Institution Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewsignori-aot @sh16011993 @dheepak-aot @guru-aot @ann-aot