Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2020 - WAVA (API Mass Assignment) - Fix location creation #2054

Merged
merged 1 commit into from
Jun 28, 2023
Merged

#2020 - WAVA (API Mass Assignment) - Fix location creation #2054

merged 1 commit into from
Jun 28, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

Fix an error during location creation. The DTO was not properly typed causing an API error during the submission due to the extra properties sent in the payload.

@andrewsignori-aot andrewsignori-aot added Bug Something isn't working Web Portal labels Jun 28, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this Jun 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.94% ( 2125 / 11843 )
Methods: 8.33% ( 126 / 1512 )
Lines: 20.74% ( 1861 / 8975 )
Branches: 10.18% ( 138 / 1356 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review June 28, 2023 03:01
@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 49.56% ( 3497 / 7056 )
Methods: 44.43% ( 407 / 916 )
Lines: 54.84% ( 2885 / 5261 )
Branches: 23.32% ( 205 / 879 )

dheepak-aot
dheepak-aot approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sh16011993
sh16011993 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrepestana-aot
andrepestana-aot approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsignori-aot andrewsignori-aot merged commit 29dc22d into main Jun 28, 2023
@andrewsignori-aot andrewsignori-aot deleted the fix/#2020-fix-endpoints branch June 28, 2023 17:36
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:50 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:52 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:52 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:52 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:52 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:57 — with GitHub Actions Inactive
@andrewsignori-aot andrewsignori-aot temporarily deployed to DEV June 28, 2023 17:57 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@guru-aot guru-aot Awaiting requested review from guru-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewsignori-aot @sh16011993 @dheepak-aot @ann-aot @andrepestana-aot