#2033 - Validating FT and PT offering minimum length #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
requested review from
andrewsignori-aot,
sh16011993,
guru-aot,
ann-aot,
andrepestana-aot and
JasonCTang
guru-aot
reviewed
Jun 27, 2023
| @@ -23,20 +20,32 @@ class HasValidOfferingPeriodForFundedDaysConstraint | |||
| implements ValidatorConstraintInterface | |||
| { | |||
| validate(studyBreaks: StudyBreak[], args: ValidationArguments): boolean { | |||
| const offeringMinDaysAllowedValue = this.getOfferingMinAllowedDays(args); | |||
There was a problem hiding this comment.
Nice implementation to pass the args from the form with respect to the offering intensity, but can this be shared done as a constant without passing them from the form?
guru-aot
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Nice work @dheepak-aot, just a doubt I have to better understand the implementation.
|
ann-aot
reviewed
Jun 27, 2023
...es/education-program-offering/custom-validators/has-valid-offering-period-for-funded-days.ts
Show resolved
Hide resolved
ann-aot
reviewed
Jun 27, 2023
sources/packages/forms/src/form-definitions/educationprogramoffering.json
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Jun 27, 2023
...kages/backend/apps/api/src/utilities/class-validation/custom-validators/period-min-length.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Jun 27, 2023
| private getMinAllowedDays(args: ValidationArguments): number { | ||
| const [, minDaysAllowed] = args.constraints; | ||
| const minDaysAllowedValue = | ||
| minDaysAllowed instanceof Function |
andrepestana-aot
approved these changes
Jun 27, 2023
Yes @ann-aot the intention was to show one happy path of bulk offering upload testing. |
.../api/src/services/education-program-offering/education-program-offering-validation.models.ts
Outdated
Show resolved
Hide resolved
...kages/backend/apps/api/src/utilities/class-validation/custom-validators/period-min-length.ts
Outdated
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/educationprogramoffering.json
Show resolved
Hide resolved
sh16011993
approved these changes
Jun 27, 2023
guru-aot
approved these changes
Jun 27, 2023
ann-aot
approved these changes
Jun 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
andrewsignori-aot
approved these changes
Jun 27, 2023
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the minimum offering length validation as per offering intensity
@PeriodMinLengthdecorator to accept either a function or a value forminDaysAllowed.When the same decorator is used for offering validation, the function
studyPeriodMinLengthis assigned to minAllowedDays which calculates minAllowedDays based on offering intensity.@HasValidOfferingPeriodForFundedDaysdecorator to have an additional argument to get the minimum allowed days for offering and not use a direct value from constant. The third argument is a function which provides the minimum allowed days based on the offering intensity.educationprogramofferingform to have client side hidden variables to get minimum and maximum days for study period length and display the banner messaged using the variables.Full Time
Part Time
Bulk offering upload testing