Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1997 - Fix camunda deployments #2038

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jun 21, 2023

Close Zeebe connection on camunda deployments

We have an ongoing issue on camunda definition deployments when deploying to camunda SaaS not in local.

The deployment gets executed but the command does not terminate(happens in local and github actions as well).

zeebeClient.close() has been added to code and tested that it fixes the issue.

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank You Dheepak for fixing the issue.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dheepak-aot dheepak-aot self-assigned this Jun 21, 2023
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the fix, looks good 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.94% ( 2116 / 11792 )
Methods: 8.24% ( 124 / 1504 )
Lines: 20.73% ( 1854 / 8942 )
Branches: 10.25% ( 138 / 1346 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 49.71% ( 3475 / 6990 )
Methods: 44.58% ( 403 / 904 )
Lines: 54.97% ( 2869 / 5219 )
Branches: 23.41% ( 203 / 867 )

@dheepak-aot dheepak-aot merged commit b2ea8ce into main Jun 21, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:40 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:42 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:42 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:42 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:42 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV June 21, 2023 18:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the fix/#1997-fix-camunda-deployments branch June 21, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants