#1997 - Upgrade Zeebe node version #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GRPC resource exhauted error.
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
|
Kudos, SonarCloud Quality Gate passed!
|
dheepak-aot
requested review from
andrewsignori-aot,
guru-aot,
ann-aot,
andrepestana-aot,
sh16011993 and
JasonCTang
dheepak-aot
added
Camunda Worflow
guru-aot
approved these changes
Jun 20, 2023
ann-aot
reviewed
Jun 20, 2023
| @@ -86,7 +87,7 @@ export interface AssessmentConsolidatedData { | |||
| studentDataPartnerStudyWeeks?: number; | |||
| studentDataPartnerEmploymentInsurance?: YesNoOptions; | |||
| studentDataPartnerFedralProvincialPDReceiptCost?: number; | |||
| studentDataParentDependentTable?: unknown; | |||
| studentDataParentDependentTable?: JSONDoc; | |||
There was a problem hiding this comment.
just to check, should this be a list of JSONDoc
There was a problem hiding this comment.
May be. But we never populated data to these values in tests, so kept it as JSONDoc. When we create an interface to this value in future we can update to list of that interface that extends JSONDoc.
ann-aot
approved these changes
Jun 20, 2023
andrewsignori-aot
approved these changes
Jun 20, 2023
andrepestana-aot
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Zeebe node version
createProcessInstanceWithResult()of Zeebe client.Note
Initial effort was to upgrade to Zeebe 8.2.4 latest version of zeebe node (https://www.npmjs.com/package/zeebe-node?activeTab=versions) but upgrading to latest version brought back the GRPC resource exhausted error logs.
Hence upgrading with second latest/penultimate version 8.2.3.