#2003 - Basic e2e tests for the low coverage parts of the application #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepestana-aot
requested review from
ann-aot,
andrewsignori-aot,
sh16011993,
dheepak-aot,
guru-aot and
JasonCTang
sh16011993
reviewed
Jun 14, 2023
...ts_/e2e/designation-agreement.institutions.controller.submitDesignationAgreement.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
reviewed
Jun 14, 2023
...-program-offering/_tests_/education-program-offering.institutions.createOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
reviewed
Jun 14, 2023
...-program-offering/_tests_/education-program-offering.institutions.createOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
reviewed
Jun 14, 2023
...-program-offering/_tests_/education-program-offering.institutions.createOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
reviewed
Jun 14, 2023
...m-offering/_tests_/education-program-offering.institutions.updateProgramOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
reviewed
Jun 14, 2023
...m-offering/_tests_/education-program-offering.institutions.updateProgramOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
ann-aot
reviewed
Jun 14, 2023
...ts_/e2e/designation-agreement.institutions.controller.submitDesignationAgreement.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sh16011993
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thank you @andrepestana-aot for making the minor update. Looks good to me 👍
guru-aot
approved these changes
Jun 15, 2023
dheepak-aot
reviewed
Jun 15, 2023
...gram-offering/_tests_/e2e/education-program-offering.institutions.createOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jun 15, 2023
...ram/_tests_/e2e/education-program.institutions.controller.createEducationProgram.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jun 15, 2023
| @@ -29,5 +30,6 @@ export function createFakeEducationProgramOffering( | |||
| offering.courseLoad = 45; | |||
| offering.hasOfferingWILComponent = "no"; | |||
| offering.offeringDeclaration = true; | |||
| offering.offeringStatus = OfferingStatus.CreationPending; | |||
There was a problem hiding this comment.
I feel that looking at the overall purpose of this factory, offering status must be defaulted to approved, with supporting data. IMO Creation pending offering is only useful for those tests which check the initial status of the offering and otherwise we always would need an approved offering.
|
Thanks for adding tests and improving the coverage. Please have a look at the comments. |
andrewsignori-aot
approved these changes
Jun 16, 2023
ann-aot
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Good work @andrepestana-aot 👍 Thanks for doing the changes. I think you missed one comment #2012 (comment), please take a look
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created e2e basic tests for:
Changed designation agreement factory to create entities with "Approved" status because the tests that create them need that the institution does not have any previous designation agreements with "Pending" status.