#1917 - Fix deployment #1994
Merged
#1917 - Fix deployment #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsignori-aot
requested review from
ann-aot,
dheepak-aot,
andrepestana-aot,
JasonCTang and
sh16011993
guru-aot
approved these changes
Jun 6, 2023
ann-aot
reviewed
Jun 6, 2023
| echo OC CLI Version: $(oc version) | ||
|
|
||
| # Create new tag. | ||
| # # Create new tag. |
There was a problem hiding this comment.
Leftover from when I was commenting and uncommenting the code. Just removed it.
ann-aot
reviewed
Jun 6, 2023
| @@ -29,10 +30,10 @@ on: | |||
| type: string | |||
| deployCamundaDefinitions: | |||
| required: true | |||
| type: string | |||
| type: boolean | |||
ann-aot
approved these changes
Jun 6, 2023
| @@ -73,7 +74,7 @@ jobs: | |||
| ref: ${{ needs.createTag.outputs.newTag }} | |||
| - name: Log in to OpenShift | |||
| run: | | |||
| oc login --token=${{ secrets.SA_TOKEN }} --server=https://api.silver.devops.gov.bc.ca:6443 | |||
| oc login --token=${{ secrets.SA_TOKEN }} --server=${{ vars.OPENSHIFT_CLUSTER_URL }} | |||
There was a problem hiding this comment.
One advantage of having those vars is that if the value changes it is only one place to be changed.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.event.inputswithinputs. The first one failed for the reusable workflows calls (see additional context).OPENSHIFT_CLUSTER_URLandBUILD_NAMESPACEas per @dheepak-aot suggestion in the previous PR.deployCamundaDefinitionsanddeployFormioDefinitionsare now booleans.run-nameto make the workflow execution clear.