Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1990 - Camunda Workers - Add Redis env variables #1991

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

ann-aot
Copy link
Contributor

@ann-aot ann-aot commented Jun 5, 2023

  • Added Redis related variable for workers-deploy.yml

@ann-aot ann-aot self-assigned this Jun 5, 2023
@ann-aot ann-aot marked this pull request as ready for review June 5, 2023 17:48
@ann-aot ann-aot added the Devops Devops label Jun 5, 2023
@@ -33,6 +33,8 @@ objects:
value: ${NODE_ENV}
- name: POSTGRES_HOST
value: "${DB_SERVICE}"
- name: REDIS_HOST
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep REDIS_HOST and REDIS_PASSWORD together?

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks good just a little comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.95% ( 2091 / 11650 )
Methods: 8.23% ( 123 / 1494 )
Lines: 20.73% ( 1832 / 8838 )
Branches: 10.32% ( 136 / 1318 )

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.39% ( 3021 / 6962 )
Methods: 37.65% ( 340 / 903 )
Lines: 48.49% ( 2520 / 5197 )
Branches: 18.68% ( 161 / 862 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ann-aot ann-aot merged commit b20c84d into main Jun 5, 2023
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:47 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 18:49 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 19:05 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 19:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 19:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 19:06 — with GitHub Actions Inactive
@ann-aot ann-aot temporarily deployed to DEV June 5, 2023 19:06 — with GitHub Actions Inactive
@ann-aot ann-aot deleted the fix/sims-#1990 branch June 5, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants