Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1867 - Fix SonarCloud security hotspots #1974

Merged
merged 1 commit into from
May 29, 2023
Merged

#1867 - Fix SonarCloud security hotspots #1974

merged 1 commit into from
May 29, 2023

Conversation

sh16011993
Copy link
Collaborator

As a part of this PR, removed the redundant nonroot user from the Dockerfiles.

@sh16011993 sh16011993 linked an issue May 29, 2023 that may be closed by this pull request
Fix Sonarcloud high security issues #1867
Closed
2 tasks
@sh16011993 sh16011993 self-assigned this May 29, 2023
@sh16011993 sh16011993 added the Sonar Involves fixing sonar related issues label May 29, 2023
@sh16011993 sh16011993 requested a review from guru-aot May 29, 2023 19:04
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.69% ( 2060 / 11646 )
Methods: 7.9% ( 118 / 1493 )
Lines: 20.47% ( 1809 / 8836 )
Branches: 10.1% ( 133 / 1317 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.42% ( 3022 / 6960 )
Methods: 37.65% ( 340 / 903 )
Lines: 48.52% ( 2521 / 5196 )
Branches: 18.7% ( 161 / 861 )

andrewsignori-aot
andrewsignori-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andrepestana-aot
andrepestana-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sh16011993

@sh16011993 sh16011993 merged commit e827b1c into main May 29, 2023
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 21:51 — with GitHub Actions Inactive
@sh16011993 sh16011993 deleted the 1867_fix_sonarcloud_security_hotspots branch May 29, 2023 21:51
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 21:52 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 21:52 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 21:52 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:29 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:30 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:30 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:30 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 22:30 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@dheepak-aot dheepak-aot Awaiting requested review from dheepak-aot

@hellolynn-tbtb hellolynn-tbtb Awaiting requested review from hellolynn-tbtb

@ann-aot ann-aot Awaiting requested review from ann-aot

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@sh16011993 sh16011993

Labels
Sonar Involves fixing sonar related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Sonarcloud high security issues
4 participants
@sh16011993 @andrewsignori-aot @guru-aot @andrepestana-aot