#1966 - Fix sonarcloud critical and major issues (part 2) #1973
+61
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
requested review from
andrepestana-aot,
andrewsignori-aot and
dheepak-aot
sh16011993
requested review from
ann-aot,
hellolynn-tbtb,
guru-aot and
JasonCTang
| @@ -129,7 +129,7 @@ export class DisbursementScheduleSharedService extends RecordDataModelService<Di | |||
| assessment.modifier = auditUser; | |||
| // Adjust the saved grants disbursements with the values already disbursed. | |||
| // !Intended to process only grants (CanadaGrant/BCGrant) | |||
| this.applyGrantsAlreadyDisbursedValues( | |||
| await this.applyGrantsAlreadyDisbursedValues( | |||
There was a problem hiding this comment.
I believe that the method is wrongly marked with async. Please check if the async can be removed from the method and remove the await add here.
guru-aot
reviewed
May 29, 2023
ann-aot
reviewed
May 29, 2023
ann-aot
reviewed
May 29, 2023
| @@ -487,10 +487,10 @@ export class DisbursementScheduleSharedService extends RecordDataModelService<Di | |||
| * @param totalAlreadyDisbursedValues sum of the awards already | |||
| * disbursed per award code. | |||
| */ | |||
| private async applyGrantsAlreadyDisbursedValues( | |||
| private applyGrantsAlreadyDisbursedValues( | |||
|
Kudos, SonarCloud Quality Gate passed!
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
Backend Unit Tests Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, fixed the major issues (bugs) reported by SonarCloud.