Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1966 - Fix sonarcloud critical and major issues (part 2) #1973

Merged
merged 7 commits into from
May 29, 2023
Merged

#1966 - Fix sonarcloud critical and major issues (part 2) #1973

merged 7 commits into from
May 29, 2023

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented May 29, 2023 •
edited
Loading

As a part of this PR, fixed the major issues (bugs) reported by SonarCloud.

@sh16011993 sh16011993 self-assigned this May 29, 2023
@sh16011993 sh16011993 added the Sonar Involves fixing sonar related issues label May 29, 2023
@sh16011993 sh16011993 linked an issue May 29, 2023 that may be closed by this pull request
Fix SonarCloud critical and major Issues #1966
Closed
andrewsignori-aot
andrewsignori-aot reviewed May 29, 2023
View reviewed changes
...ages/backend/libs/services/src/disbursement-schedule/disbursement-schedule-shared.service.ts Outdated
@@ -129,7 +129,7 @@ export class DisbursementScheduleSharedService extends RecordDataModelService<Di
assessment.modifier = auditUser;
// Adjust the saved grants disbursements with the values already disbursed.
// !Intended to process only grants (CanadaGrant/BCGrant)
this.applyGrantsAlreadyDisbursedValues(
await this.applyGrantsAlreadyDisbursedValues(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the method is wrongly marked with async. Please check if the async can be removed from the method and remove the await add here.

andrewsignori-aot
andrewsignori-aot reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking the issues, please take a look at the comments.

andrepestana-aot
andrepestana-aot reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Just take a look at Andrew's comments.

guru-aot
guru-aot reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the review, please have a look on the other Devs comments.

ann-aot
ann-aot reviewed May 29, 2023
View reviewed changes
...ages/backend/libs/services/src/disbursement-schedule/disbursement-schedule-shared.service.ts
@@ -487,10 +487,10 @@ export class DisbursementScheduleSharedService extends RecordDataModelService<Di
* @param totalAlreadyDisbursedValues sum of the awards already
* disbursed per award code.
*/
private async applyGrantsAlreadyDisbursedValues(
private applyGrantsAlreadyDisbursedValues(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.69% ( 2060 / 11648 )
Methods: 7.9% ( 118 / 1494 )
Lines: 20.47% ( 1809 / 8837 )
Branches: 10.1% ( 133 / 1317 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.42% ( 3022 / 6960 )
Methods: 37.65% ( 340 / 903 )
Lines: 48.52% ( 2521 / 5196 )
Branches: 18.7% ( 161 / 861 )

andrewsignori-aot
andrewsignori-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Looks good 👍

ann-aot
ann-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work @sh16011993

andrepestana-aot
andrepestana-aot approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sh16011993 sh16011993 merged commit 1857604 into main May 29, 2023
@sh16011993 sh16011993 deleted the 1966_fix_sonarcloud_major_issues branch May 29, 2023 23:05
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:05 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:23 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:25 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:25 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:25 — with GitHub Actions Inactive
@sh16011993 sh16011993 temporarily deployed to DEV May 29, 2023 23:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot left review comments

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@dheepak-aot dheepak-aot Awaiting requested review from dheepak-aot

@hellolynn-tbtb hellolynn-tbtb Awaiting requested review from hellolynn-tbtb

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@sh16011993 sh16011993

Labels
Sonar Involves fixing sonar related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SonarCloud critical and major Issues
5 participants
@sh16011993 @andrewsignori-aot @guru-aot @ann-aot @andrepestana-aot